isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-16 21:34:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

wayland: Drop error trap

Browse Source 
Code underneath seems to handle errors properly, or be x11-agnostic
entirely, this is apparently here to save a few XSync()s on X11. Just
drop this windowing dependent bit to make things cleaner.

https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
This commit is contained in:
Carlos Garnacho 2019-02-25 18:47:59 +01:00 committed by Jonas Ådahl
parent 38432da328
commit ea9d8a895b
1 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/wayland/meta-window-wayland.c
View File

@ -655,7 +655,6 @@ meta_window_wayland_new (MetaDisplay *display,
MetaWaylandSurface *surface) MetaWaylandSurface *surface)
{ {
XWindowAttributes attrs = { 0 }; XWindowAttributes attrs = { 0 };
MetaWindow *window;
/* /*
* Set attributes used by _meta_window_shared_new, don't bother trying to fake * Set attributes used by _meta_window_shared_new, don't bother trying to fake
@ -670,26 +669,13 @@ meta_window_wayland_new (MetaDisplay *display,
attrs.map_state = IsUnmapped; attrs.map_state = IsUnmapped;
attrs.override_redirect = False; attrs.override_redirect = False;
/* XXX: Note: In the Wayland case we currently still trap X errors while return _meta_window_shared_new (display,
* creating a MetaWindow because we will still be making various redundant META_WINDOW_CLIENT_TYPE_WAYLAND,
* X requests (passing a window xid of None) until we thoroughly audit all surface,
* the code to make sure it knows about non X based clients... None,
*/ WithdrawnState,
meta_x11_error_trap_push (display->x11_display); /* Push a trap over all of window META_COMP_EFFECT_CREATE,
* creation, to reduce XSync() calls &attrs);
*/
window = _meta_window_shared_new (display,
META_WINDOW_CLIENT_TYPE_WAYLAND,
surface,
None,
WithdrawnState,
META_COMP_EFFECT_CREATE,
&attrs);
meta_x11_error_trap_pop (display->x11_display); /* pop the XSync()-reducing trap */
return window;
} }
static gboolean static gboolean