mirror of
https://github.com/brl/mutter.git
synced 2024-11-10 07:56:14 -05:00
x11/window: Ensure we send a ConfigureNotify to just mapped windows
When managing a non-OR window we're required by the ICCCM to behave as if we received a ConfigureRequest which means that we must generate a synthetic ConfigureNotify even if the window isn't moved or resized from its current (initial) geometry. During MetaWindow's x11/wayland split a slight behavior change for x11 windows crept in. Before the code split, MetaWindow->rect was initialized with the X window's geometry, but now we're not initializing MetaWindowX11Private->client_rect which causes the checks for whether it's necessary to move/resize the window in meta_window_x11_move_resize_internal() to tell us that we do need to move/resize which means we do an XConfigureWindow() call and don't send the sythetic ConfigureNotify. But since the X window isn't really moving, the XConfigureWindow() call doesn't cause the X server to generate a ConfigureNotify which breaks some clients such as Java's AWT. We can fix this by setting MetaWindowX11Privatew->client_rect for both OR and non-OR windows. We can set buffer_rect for non-OR windows as well to simplify the code since it will be assigned the correct value in meta_window_x11_move_resize_internal() . https://bugzilla.gnome.org/show_bug.cgi?id=759492
This commit is contained in:
parent
49ea6486e2
commit
e7390cff83
@ -542,13 +542,10 @@ meta_window_x11_manage (MetaWindow *window)
|
|||||||
* For normal windows, do a full ConfigureRequest based on the
|
* For normal windows, do a full ConfigureRequest based on the
|
||||||
* window hints, as that's what the ICCCM says to do.
|
* window hints, as that's what the ICCCM says to do.
|
||||||
*/
|
*/
|
||||||
|
priv->client_rect = window->rect;
|
||||||
|
window->buffer_rect = window->rect;
|
||||||
|
|
||||||
if (window->override_redirect)
|
if (!window->override_redirect)
|
||||||
{
|
|
||||||
priv->client_rect = window->rect;
|
|
||||||
window->buffer_rect = window->rect;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
{
|
||||||
MetaRectangle rect;
|
MetaRectangle rect;
|
||||||
MetaMoveResizeFlags flags;
|
MetaMoveResizeFlags flags;
|
||||||
|
Loading…
Reference in New Issue
Block a user