From e053f7f2f455ebf358e64ed56dd42015b7f94591 Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Sat, 14 Dec 2013 14:22:40 +0100 Subject: [PATCH] window: fix invalid read in computing the input shape If we are reported only one rectangle in the input shape, we should not try to read more. https://bugzilla.gnome.org/show_bug.cgi?id=724257 --- src/core/window.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/window.c b/src/core/window.c index 7ea609d93..c6666ba88 100644 --- a/src/core/window.c +++ b/src/core/window.c @@ -7830,9 +7830,9 @@ meta_window_update_input_region_x11 (MetaWindow *window) if (n_rects > 1 || (n_rects == 1 && (rects[0].x != x_bounding || - rects[1].y != y_bounding || - rects[2].width != w_bounding || - rects[3].height != h_bounding))) + rects[0].y != y_bounding || + rects[0].width != w_bounding || + rects[0].height != h_bounding))) region = region_create_from_x_rectangles (rects, n_rects); XFree (rects);