isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-16 13:24:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

clutter/actor: Don't push identity transforms

Browse Source 
It is useless, and needlessly increases the matrix stack and
does more multiplications than necessary.

Don't push identity transforms to the pick stack.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509
This commit is contained in:
Georges Basile Stavracas Neto 2020-10-18 14:29:13 -03:00
parent ce6f13357a
commit da7671b547
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clutter/clutter/clutter-actor.c
View File

@ -3931,6 +3931,7 @@ clutter_actor_pick (ClutterActor *actor,
{
ClutterActorPrivate *priv;
ClutterActorBox clip;
gboolean transform_pushed = FALSE;
gboolean clip_set = FALSE;
if (CLUTTER_ACTOR_IN_DESTRUCTION (actor))
@ -3953,7 +3954,11 @@ clutter_actor_pick (ClutterActor *actor,
graphene_matrix_init_identity (&matrix);
_clutter_actor_apply_modelview_transform (actor, &matrix);
clutter_pick_context_push_transform (pick_context, &matrix);
if (!graphene_matrix_is_identity (&matrix))
{
clutter_pick_context_push_transform (pick_context, &matrix);
transform_pushed = TRUE;
}
}
if (priv->has_clip)
@ -3988,7 +3993,7 @@ clutter_actor_pick (ClutterActor *actor,
if (clip_set)
clutter_pick_context_pop_clip (pick_context);
if (priv->enable_model_view_transform)
if (transform_pushed)
clutter_pick_context_pop_transform (pick_context);
/* paint sequence complete */