tests/stacking: Don't test for time-dependent intermediate focus state

While c3d13203 ensured that the test-client has actually closed the
window before testing for the focus change, it also made another timing
related issue with the tests more likely to happen. Serveral tests
assert that the focus is set to 'none' after the focussed window has
been closed when the window below does not accept focus. This however
can never be reliably tested, because closing the window triggers
timeout based iteration of a queue of default focus candidate windows.
This starts after the window has been closed and might finish before the
clients have finished synchronizing. This issue is more likely to
trigger the shorter the queue is and the more test clients there are
that could delay the synchronization.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1329
This commit is contained in:
Sebastian Keller 2020-06-26 21:31:10 +02:00 committed by Georges Basile Stavracas Neto
parent 4c0aa2afca
commit d830d985c1
4 changed files with 0 additions and 4 deletions

View File

@ -22,7 +22,6 @@ assert_stacking 2/1 1/1 1/2 1/3
destroy 1/3 destroy 1/3
wait wait
assert_focused none
assert_stacking 2/1 1/1 1/2 assert_stacking 2/1 1/1 1/2
activate 2/1 activate 2/1

View File

@ -22,7 +22,6 @@ assert_stacking 2/1 1/1 1/2 1/3
destroy 1/3 destroy 1/3
wait wait
assert_focused none
assert_stacking 2/1 1/1 1/2 assert_stacking 2/1 1/1 1/2
sleep 150 sleep 150

View File

@ -32,7 +32,6 @@ assert_stacking 0/1 1/1 1/2 1/3 1/4 1/5
destroy 1/5 destroy 1/5
wait wait
assert_focused none
assert_stacking 0/1 1/1 1/2 1/3 1/4 assert_stacking 0/1 1/1 1/2 1/3 1/4
destroy 1/2 destroy 1/2

View File

@ -32,7 +32,6 @@ assert_stacking 0/1 1/1 1/2 1/3 1/4 1/5
destroy 1/5 destroy 1/5
wait wait
assert_focused none
assert_stacking 0/1 1/1 1/2 1/3 1/4 assert_stacking 0/1 1/1 1/2 1/3 1/4
sleep 600 sleep 600