From ca64a308eb4850549529105ca00c03da6038f46d Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Tue, 28 Jul 2020 09:48:03 +0200 Subject: [PATCH] surface-actor: Restore drop shadow with server-side decorations Commit 510cbef15a changed the logic in `handle_update()` for X11 window actors to return early if the surface is not an X11 surface. That works fine for plain Xorg, but on Xwayland, the surface is actually a Wayland surface, therefore the function returns early before updating the drop shadows of server-side decorations for X11 windows. Change the test logic to restore drops shadows with Xwayland windows. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1384 Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/1358 --- src/compositor/meta-window-actor-x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor/meta-window-actor-x11.c b/src/compositor/meta-window-actor-x11.c index a2bc1d939..9ea907b3c 100644 --- a/src/compositor/meta-window-actor-x11.c +++ b/src/compositor/meta-window-actor-x11.c @@ -1223,7 +1223,7 @@ handle_updates (MetaWindowActorX11 *actor_x11) meta_surface_actor_x11_handle_updates (surface_x11); } - if (!META_IS_SURFACE_ACTOR_X11 (surface) || + if (META_IS_SURFACE_ACTOR_X11 (surface) && !meta_surface_actor_x11_is_visible (META_SURFACE_ACTOR_X11 (surface))) return;