isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-25 09:30:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

clutter/backend: Don't dispatch libinput events too early

Browse Source 
At startup, libinput dispatch is called from the MetaSeatNative
constructed callback.

That means that we may get libinput events even before the default seat
is set.

In turn, processing those events may trigger the use the default seat
while it's still not set yet, and cause a crash of gnome-shell/mutter
at startup.

A simple reproducer for this is to start gnome-shell/mutter with a
tablet connected and the stylus in proximity, the proximity event will
cause gnome-shell/mutter to crash at startup.

To avoid that issue, avoid dispatching libinput events early from the
MetaSeatNative constructed callback, those events will eventually get
processed when the seat and the backend are all setup.

https://gitlab.gnome.org/GNOME/mutter/-/issues/1501
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1534
This commit is contained in:
Olivier Fourdan 2020-10-27 10:27:48 +01:00
parent eaa6efef56
commit c618b8a0eb
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backends/native/meta-seat-native.c
View File

@ -2537,8 +2537,6 @@ meta_seat_native_constructed (GObject *object)
seat->udev_client = g_udev_client_new ((const gchar *[]) { "input", NULL }); seat->udev_client = g_udev_client_new ((const gchar *[]) { "input", NULL });
dispatch_libinput (seat);
source = meta_event_source_new (seat); source = meta_event_source_new (seat);
seat->event_source = source; seat->event_source = source;