mirror of
https://github.com/brl/mutter.git
synced 2024-11-26 18:11:05 -05:00
clutter/actor: Remove outdated comment
Updating of the paint volume used for culling these days happens during the finish-layout stage, not while painting. Also we have geometry-based, not paint-based picking anymore. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1492>
This commit is contained in:
parent
0aba87308a
commit
c40feb33fa
@ -3738,33 +3738,6 @@ clutter_actor_paint (ClutterActor *self,
|
|||||||
*/
|
*/
|
||||||
add_or_remove_flatten_effect (self);
|
add_or_remove_flatten_effect (self);
|
||||||
|
|
||||||
/* We save the current paint volume so that the next time the
|
|
||||||
* actor queues a redraw we can constrain the redraw to just
|
|
||||||
* cover the union of the new bounding box and the old.
|
|
||||||
*
|
|
||||||
* We also fetch the current paint volume to perform culling so
|
|
||||||
* we can avoid painting actors outside the current clip region.
|
|
||||||
*
|
|
||||||
* If we are painting inside a clone, we should neither update
|
|
||||||
* the paint volume or use it to cull painting, since the paint
|
|
||||||
* box represents the location of the source actor on the
|
|
||||||
* screen.
|
|
||||||
*
|
|
||||||
* XXX: We are starting to do a lot of vertex transforms on
|
|
||||||
* the CPU in a typical paint, so at some point we should
|
|
||||||
* audit these and consider caching some things.
|
|
||||||
*
|
|
||||||
* NB: We don't perform culling while picking at this point because
|
|
||||||
* clutter-stage.c doesn't setup the clipping planes appropriately.
|
|
||||||
*
|
|
||||||
* NB: We don't want to update the last-paint-volume during picking
|
|
||||||
* because the last-paint-volume is used to determine the old screen
|
|
||||||
* space location of an actor that has moved so we can know the
|
|
||||||
* minimal region to redraw to clear an old view of the actor. If we
|
|
||||||
* update this during picking then by the time we come around to
|
|
||||||
* paint then the last-paint-volume would likely represent the new
|
|
||||||
* actor position not the old.
|
|
||||||
*/
|
|
||||||
culling_inhibited = priv->inhibit_culling_counter > 0;
|
culling_inhibited = priv->inhibit_culling_counter > 0;
|
||||||
if (!culling_inhibited && !in_clone_paint ())
|
if (!culling_inhibited && !in_clone_paint ())
|
||||||
{
|
{
|
||||||
|
Loading…
Reference in New Issue
Block a user