isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-28 11:00:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

workspace: Add :active convenience property

Browse Source 
There are a couple of places in gnome-shell where we aren't interested
in which workspace is active, but whether a given workspace is active.

Of course it's easy to use the former to determine the latter, but we
can offer a convenience property on the workspace itself almost for
free, so let's do that.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1336
This commit is contained in:
Florian Müllner 2020-06-29 01:06:30 +02:00 committed by Georges Basile Stavracas Neto
parent 1142f06af5
commit c1933cfd09
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/core/workspace.c
View File

@ -62,6 +62,7 @@ enum
PROP_N_WINDOWS, PROP_N_WINDOWS,
PROP_WORKSPACE_INDEX, PROP_WORKSPACE_INDEX,
PROP_ACTIVE,
PROP_LAST, PROP_LAST,
}; };
@ -179,6 +180,9 @@ meta_workspace_get_property (GObject *object,
case PROP_WORKSPACE_INDEX: case PROP_WORKSPACE_INDEX:
g_value_set_uint (value, meta_workspace_index (ws)); g_value_set_uint (value, meta_workspace_index (ws));
break; break;
case PROP_ACTIVE:
g_value_set_boolean (value, ws->manager->active_workspace == ws);
break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break; break;
@ -218,6 +222,11 @@ meta_workspace_class_init (MetaWorkspaceClass *klass)
"The workspace's index", "The workspace's index",
0, G_MAXUINT, 0, 0, G_MAXUINT, 0,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS); G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_ACTIVE] = g_param_spec_boolean ("active",
"Active",
"Whether the workspace is currently active",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
g_object_class_install_properties (object_class, PROP_LAST, obj_props); g_object_class_install_properties (object_class, PROP_LAST, obj_props);
} }
@ -551,9 +560,13 @@ meta_workspace_activate_with_focus (MetaWorkspace *workspace,
g_signal_emit_by_name (workspace->manager, "active-workspace-changed"); g_signal_emit_by_name (workspace->manager, "active-workspace-changed");
g_object_notify_by_pspec (G_OBJECT (workspace), obj_props[PROP_ACTIVE]);
if (old == NULL) if (old == NULL)
return; return;
g_object_notify_by_pspec (G_OBJECT (old), obj_props[PROP_ACTIVE]);
/* If the "show desktop" mode is active for either the old workspace /* If the "show desktop" mode is active for either the old workspace
* or the new one *but not both*, then update the * or the new one *but not both*, then update the
* _net_showing_desktop hint * _net_showing_desktop hint