From c1724eff6096033de4931fbc03ead14c71f252f5 Mon Sep 17 00:00:00 2001 From: Robert Bragg Date: Tue, 15 Oct 2013 14:04:12 +0100 Subject: [PATCH] framebuffer: NOP _set_color_mask if mask isn't changing This makes cogl_framebuffer_set_color_mask immediately bail out if the given mask equals the framebuffer's current mask, since the cost of flushing the journal and flushing the gl state will hugely outweigh the cost of the check. Reviewed-by: Neil Roberts (cherry picked from commit 925174d99df7f1f4b11098e748bcc23eaa396a21) --- cogl/cogl-framebuffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cogl/cogl-framebuffer.c b/cogl/cogl-framebuffer.c index 6b916cca6..20863ffd0 100644 --- a/cogl/cogl-framebuffer.c +++ b/cogl/cogl-framebuffer.c @@ -1248,6 +1248,9 @@ void cogl_framebuffer_set_color_mask (CoglFramebuffer *framebuffer, CoglColorMask color_mask) { + if (framebuffer->color_mask == color_mask) + return; + /* XXX: Currently color mask changes don't go through the journal */ _cogl_framebuffer_flush_journal (framebuffer);