From b809f3dc85bf336578a87033a591288e76ed5f0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michel=20D=C3=A4nzer?= Date: Wed, 31 May 2023 14:45:14 +0200 Subject: [PATCH] ci: Use "when: on_success" in job rules Instead of "when: always". The latter would result in jobs running even after a dependency job failed, which would inevitably result in the dependent job failing as well. See https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2628#note_1758824 for an example. Part-of: --- .gitlab-ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6c733a6a0..4ebc94357 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -215,7 +215,7 @@ workflow: - if: '$CI_MERGE_REQUEST_TARGET_BRANCH_NAME =~ /^$/' when: never - if: $CI_MERGE_REQUEST_TARGET_BRANCH_NAME - when: always + when: on_success check-commit-log: extends: @@ -547,7 +547,7 @@ can-build-gnome-shell@x86_64: test-mutter-coverity: rules: - if: '$CI_PIPELINE_SOURCE == "schedule" && $MUTTER_SCHEDULED_JOB == "coverity"' - when: always + when: on_success - if: '$CI_COMMIT_BRANCH' when: 'manual' extends: @@ -597,11 +597,11 @@ dist-mutter: changes: - "**/meson.build" - meson/* - when: always + when: on_success - if: '$GITLAB_USER_LOGIN == "marge-bot"' - when: always + when: on_success - if: '$CI_MERGE_REQUEST_ASSIGNEES == "marge-bot"' - when: always + when: on_success dist-mutter-tarball: extends: dist-mutter