mirror of
https://github.com/brl/mutter.git
synced 2024-12-23 19:42:05 +00:00
backends/native: Unref/unset key repeat GSource when cleared
This GSource is not being properly unref nor the variable holding it cleared. This on one hand leaks the GSource memory, on the other hand may trigger warnings in keyboard_repeat() as the source may be (reentrantly) cleared, yet we don't exit early as seat_impl->repeat_source is never NULL. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1839>
This commit is contained in:
parent
2337e0af8b
commit
b4a7f35146
@ -244,8 +244,10 @@ meta_seat_impl_clear_repeat_source (MetaSeatImpl *seat_impl)
|
||||
if (seat_impl->repeat_source)
|
||||
{
|
||||
g_source_destroy (seat_impl->repeat_source);
|
||||
g_clear_object (&seat_impl->repeat_device);
|
||||
g_clear_pointer (&seat_impl->repeat_source, g_source_unref);
|
||||
}
|
||||
|
||||
g_clear_object (&seat_impl->repeat_device);
|
||||
}
|
||||
|
||||
static void
|
||||
|
Loading…
Reference in New Issue
Block a user