From b01edc22f3cf816ec2bbc4e777fb44525a8456a8 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Thu, 16 May 2019 12:25:47 +0200 Subject: [PATCH] backends/x11: Do not reload keymap on new keyboard notifications XkbNewKeyboardNotify informs the client that there is a new keyboard driving the VCK. It is essentially meant to notify that the keyboard possibly has a different range of HW keycodes and/or a different geometry. But the translation of those keycodes remain the same, and we don't do range checks or geometry checks (beyond using KEY_GRAVE as "key under Esc", but that is hardly one). It seems we can avoid the busywork that is releasing all our passive grabs, reloading the keymap and regenerating the keycombos and restoring the passive grabs. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/398 --- src/backends/x11/meta-backend-x11.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backends/x11/meta-backend-x11.c b/src/backends/x11/meta-backend-x11.c index c10365f9d..c5794b20f 100644 --- a/src/backends/x11/meta-backend-x11.c +++ b/src/backends/x11/meta-backend-x11.c @@ -357,7 +357,6 @@ handle_host_xevent (MetaBackend *backend, { switch (xkb_ev->any.xkb_type) { - case XkbNewKeyboardNotify: case XkbMapNotify: keymap_changed (backend); break;