isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-12 03:14:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

window: Type check some wm functions

Browse Source 
These might get called from JS, so avoid crashing on bogus calls.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5952
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2661>
This commit is contained in:
Jonas Ådahl 2022-10-14 21:56:10 +02:00 committed by Marge Bot
parent 4079afe0c7
commit a331d4e45a
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/window.c
View File

@ -2463,6 +2463,7 @@ queue_calc_showing_func (MetaWindow *window,
void void
meta_window_minimize (MetaWindow *window) meta_window_minimize (MetaWindow *window)
{ {
g_return_if_fail (META_IS_WINDOW (window));
g_return_if_fail (!window->override_redirect); g_return_if_fail (!window->override_redirect);
if (!window->has_minimize_func) if (!window->has_minimize_func)
@ -2623,6 +2624,7 @@ meta_window_maximize (MetaWindow *window,
MetaRectangle *saved_rect = NULL; MetaRectangle *saved_rect = NULL;
gboolean maximize_horizontally, maximize_vertically; gboolean maximize_horizontally, maximize_vertically;
g_return_if_fail (META_IS_WINDOW (window));
g_return_if_fail (!window->override_redirect); g_return_if_fail (!window->override_redirect);
/* At least one of the two directions ought to be set */ /* At least one of the two directions ought to be set */
@ -2897,6 +2899,8 @@ update_edge_constraints (MetaWindow *window)
void void
meta_window_untile (MetaWindow *window) meta_window_untile (MetaWindow *window)
{ {
g_return_if_fail (META_IS_WINDOW (window));
window->tile_monitor_number = window->tile_monitor_number =
window->saved_maximize ? window->monitor->number window->saved_maximize ? window->monitor->number
: -1; : -1;
@ -2917,6 +2921,8 @@ meta_window_tile (MetaWindow *window,
MetaMaximizeFlags directions; MetaMaximizeFlags directions;
MetaRectangle old_frame_rect, old_buffer_rect; MetaRectangle old_frame_rect, old_buffer_rect;
g_return_if_fail (META_IS_WINDOW (window));
meta_window_get_tile_fraction (window, tile_mode, &window->tile_hfraction); meta_window_get_tile_fraction (window, tile_mode, &window->tile_hfraction);
window->tile_mode = tile_mode; window->tile_mode = tile_mode;
@ -3057,6 +3063,7 @@ meta_window_unmaximize (MetaWindow *window,
{ {
gboolean unmaximize_horizontally, unmaximize_vertically; gboolean unmaximize_horizontally, unmaximize_vertically;
g_return_if_fail (META_IS_WINDOW (window));
g_return_if_fail (!window->override_redirect); g_return_if_fail (!window->override_redirect);
/* At least one of the two directions ought to be set */ /* At least one of the two directions ought to be set */
@ -3262,6 +3269,7 @@ meta_window_make_fullscreen_internal (MetaWindow *window)
void void
meta_window_make_fullscreen (MetaWindow *window) meta_window_make_fullscreen (MetaWindow *window)
{ {
g_return_if_fail (META_IS_WINDOW (window));
g_return_if_fail (!window->override_redirect); g_return_if_fail (!window->override_redirect);
if (!window->fullscreen) if (!window->fullscreen)
@ -3289,6 +3297,7 @@ meta_window_make_fullscreen (MetaWindow *window)
void void
meta_window_unmake_fullscreen (MetaWindow *window) meta_window_unmake_fullscreen (MetaWindow *window)
{ {
g_return_if_fail (META_IS_WINDOW (window));
g_return_if_fail (!window->override_redirect); g_return_if_fail (!window->override_redirect);
if (window->fullscreen) if (window->fullscreen)