From 9a47e5c83276318e834de5d5d69108217d8f6b92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Tue, 1 Aug 2017 17:15:57 +0800 Subject: [PATCH] wayland/buffer: Add missing breaks in switch statement We'd process damage, and no matter whether it succeeded or not we'd pretend it succeeded, meaning any potential GError would be leaked. https://bugzilla.gnome.org/show_bug.cgi?id=786300 --- src/wayland/meta-wayland-buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wayland/meta-wayland-buffer.c b/src/wayland/meta-wayland-buffer.c index 63d5380be..55564492a 100644 --- a/src/wayland/meta-wayland-buffer.c +++ b/src/wayland/meta-wayland-buffer.c @@ -446,6 +446,7 @@ meta_wayland_buffer_process_damage (MetaWaylandBuffer *buffer, { case META_WAYLAND_BUFFER_TYPE_SHM: res = process_shm_buffer_damage (buffer, region, &error); + break; case META_WAYLAND_BUFFER_TYPE_EGL_IMAGE: case META_WAYLAND_BUFFER_TYPE_EGL_STREAM: case META_WAYLAND_BUFFER_TYPE_DMA_BUF: @@ -456,6 +457,7 @@ meta_wayland_buffer_process_damage (MetaWaylandBuffer *buffer, G_IO_ERROR_FAILED, "Unknown buffer type"); res = FALSE; + break; } if (!res)