From 995ee2b63857644980e0bfbfeeb34b7a0a309a1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 29 Jun 2022 19:59:21 +0200 Subject: [PATCH] tests/stage-view: Give outer container an explicit size The test case checks that the stage views of hidden actors are not updated when the views of the visible outer parent change. The check for the outer parent's updated stage views currently relies on ClutterFixedLayout not excluding hidden children in its size request: As the container doesn't contain any visible children at that point, its size would change to 0x0 and end up on no stage view (rather than the assumed two). Avoid that oddity by giving the outer container a fixed size, so that the visibility of its child doesn't affect the test when we fix ClutterFixedLayout. Part-of: --- src/tests/stage-view-tests.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/stage-view-tests.c b/src/tests/stage-view-tests.c index 4ce1a70f9..9007a6abd 100644 --- a/src/tests/stage-view-tests.c +++ b/src/tests/stage-view-tests.c @@ -395,6 +395,7 @@ meta_test_actor_stage_views_hide_parent (void) stage_views = clutter_stage_peek_stage_views (CLUTTER_STAGE (stage)); outer_container = clutter_actor_new (); + clutter_actor_set_size (outer_container, 50, 50); clutter_actor_add_child (stage, outer_container); inner_container = clutter_actor_new ();