From 909cc6c240b28556a0f57f5bbbf2fcf72281526a Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Tue, 10 Oct 2023 11:11:36 +0200 Subject: [PATCH] renderer/native: Send modifiers even without AddFb2 When running headless, only the invalid modifiers are advertised. That breaks with the NVIDIA proprietary driver which then rejects the buffers created with the invalid modifier, and that kills Xwayland, meaning that running Xwayland on top of a mutter based compositor headless is not possible. The reason the modifiers are not sent is because AddFb2 is not supported when running headless. Other compositors (weston, wlroots) would still send the modifiers even without AddFb2, and Xwayland works fine on those compositors when running headless. Remove the requirement for AddFb2 to send the modifiers, so that Xwayland can work fine on top of mutter headless with the NVIDIA proprietary driver. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3060 Part-of: --- src/backends/native/meta-renderer-native.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/backends/native/meta-renderer-native.c b/src/backends/native/meta-renderer-native.c index 4be977209..e6c653e26 100644 --- a/src/backends/native/meta-renderer-native.c +++ b/src/backends/native/meta-renderer-native.c @@ -2202,8 +2202,7 @@ meta_renderer_native_initable_init (GInitable *initable, else { renderer_native->send_modifiers = - !(flags & META_KMS_DEVICE_FLAG_DISABLE_CLIENT_MODIFIERS) && - flags & META_KMS_DEVICE_FLAG_HAS_ADDFB2; + !(flags & META_KMS_DEVICE_FLAG_DISABLE_CLIENT_MODIFIERS); } meta_topic (META_DEBUG_KMS, "Sending KMS modifiers to clients is %s",