isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-21 23:50:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Vytautus Liuolia totally rocks; he tested and debugged and tracked down

Browse Source 
2006-08-07  Elijah Newren  <newren gmail com>

	* src/window.c (intervening_user_event_occurred): Vytautus Liuolia
	totally rocks; he tested and debugged and tracked down where we
	were using the focus window's net_wm_user_time even when it was
	uninitialized.  This may fix bug 311868 and others I've heard
	about (with Valknut, IIRC).  It definitely fixes the issues Vytas
	was seeing with his single instance library.  :-)
This commit is contained in:
Elijah Newren 2006-08-09 18:32:30 +00:00 committed by Elijah Newren
parent 43b5985c20
commit 9051b70d40
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,12 @@
2006-08-07 Elijah Newren <newren gmail com>
* src/window.c (intervening_user_event_occurred): Vytautus Liuolia
totally rocks; he tested and debugged and tracked down where we
were using the focus window's net_wm_user_time even when it was
uninitialized. This may fix bug 311868 and others I've heard
about (with Valknut, IIRC). It definitely fixes the issues Vytas
was seeing with his single instance library. :-)
2006-08-07 Elijah Newren <newren gmail com> 2006-08-07 Elijah Newren <newren gmail com>
* src/constraints.c (setup_constraint_info): patch from Stéphane * src/constraints.c (setup_constraint_info): patch from Stéphane

15
src/window.c
View File

@ -1646,9 +1646,11 @@ intervening_user_event_occurred (MetaWindow *window)
{ {
meta_topic (META_DEBUG_STARTUP, meta_topic (META_DEBUG_STARTUP,
"COMPARISON (continued):\n" "COMPARISON (continued):\n"
" focus_window : %s\n" " focus_window : %s\n"
" fw->net_wm_user_time : %lu\n", " fw->net_wm_user_time_set : %d\n"
" fw->net_wm_user_time : %lu\n",
focus_window->desc, focus_window->desc,
focus_window->net_wm_user_time_set,
focus_window->net_wm_user_time); focus_window->net_wm_user_time);
} }
@ -1677,6 +1679,15 @@ intervening_user_event_occurred (MetaWindow *window)
return FALSE; return FALSE;
} }
if (focus_window != NULL &&
!focus_window->net_wm_user_time_set)
{
meta_topic (META_DEBUG_STARTUP,
"focus window, %s, doesn't have a user time set yet!\n",
window->desc);
return FALSE;
}
/* To determine the "launch" time of an application, /* To determine the "launch" time of an application,
* startup-notification can set the TIMESTAMP and the * startup-notification can set the TIMESTAMP and the
* application (usually via its toolkit such as gtk or qt) can * application (usually via its toolkit such as gtk or qt) can