isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-23 08:24:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

MetaRendererNative: don't call drmModeGetResources()

Browse Source 
There's no need to call this and we were leaking the returned memory.

https://bugzilla.gnome.org/show_bug.cgi?id=773116
This commit is contained in:
Rui Matos 2016-10-14 18:24:34 +02:00
parent 89672fad04
commit 8290e1f09a
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/backends/native/meta-renderer-native.c
View File

@ -1235,7 +1235,6 @@ meta_renderer_native_initable_init (GInitable *initable,
GError **error) GError **error)
{ {
MetaRendererNative *renderer_native = META_RENDERER_NATIVE (initable); MetaRendererNative *renderer_native = META_RENDERER_NATIVE (initable);
drmModeRes *resources;
renderer_native->gbm = gbm_create_device (renderer_native->kms_fd); renderer_native->gbm = gbm_create_device (renderer_native->kms_fd);
if (!renderer_native->gbm) if (!renderer_native->gbm)
@ -1243,25 +1242,10 @@ meta_renderer_native_initable_init (GInitable *initable,
g_set_error (error, G_IO_ERROR, g_set_error (error, G_IO_ERROR,
G_IO_ERROR_FAILED, G_IO_ERROR_FAILED,
"Failed to create gbm device"); "Failed to create gbm device");
goto err; return FALSE;
}
resources = drmModeGetResources (renderer_native->kms_fd);
if (!resources)
{
g_set_error (error, G_IO_ERROR,
G_IO_ERROR_FAILED,
"drmModeGetResources failed");
goto err_resources;
} }
return TRUE; return TRUE;
err_resources:
g_clear_pointer (&renderer_native->gbm, gbm_device_destroy);
err:
return FALSE;
} }
static void static void