From 7b9eccb489b1e886f9a275f74cc40acce9500c53 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sat, 9 Feb 2002 17:41:42 +0000 Subject: [PATCH] assign last_window prior to ++newp, so we don't try to stack windows with 2002-02-09 Havoc Pennington * src/stack.c (meta_stack_sync_to_server): assign last_window prior to ++newp, so we don't try to stack windows with respect to themselves. Fixes some obscure stacking bugs. --- ChangeLog | 6 ++++++ src/stack.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 07f00f25e..3b98b5731 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2002-02-09 Havoc Pennington + + * src/stack.c (meta_stack_sync_to_server): assign last_window + prior to ++newp, so we don't try to stack windows with respect to + themselves. Fixes some obscure stacking bugs. + 2002-02-09 Havoc Pennington * src/theme-parser.c: try to make more error message strings the diff --git a/src/stack.c b/src/stack.c index 813287ee4..9965ea403 100644 --- a/src/stack.c +++ b/src/stack.c @@ -660,7 +660,7 @@ meta_stack_sync_to_server (MetaStack *stack) /* Try to do minimal window moves to get the stack in order */ /* A point of note: these arrays include frames not client windows, * so if a client window has changed frame since last_root_children_stacked - * as saved, then we may have inefficiency, but I don't think things + * was saved, then we may have inefficiency, but I don't think things * break... */ const Window *old_stack = (Window *) stack->last_root_children_stacked->data; @@ -680,8 +680,8 @@ meta_stack_sync_to_server (MetaStack *stack) { /* Stacks are the same here, move on */ ++oldp; - ++newp; last_window = *newp; + ++newp; } else if (meta_display_lookup_x_window (stack->screen->display, *oldp) == NULL)