sort source files into these directories according to which part of the WM

2007-12-19  Havoc Pennington  <hp@redhat.com>

	* src/ui, src/core, src/include: sort source files into these
	directories according to which part of the WM they are supposed to
	be in. In an eventual plan, we should also create
	src/compositor/render, src/compositor/fallback and move some of
	the compositor stuff into that.
	
	* autogen.sh: require a newer automake, so we don't have to use
	a recursive build

	* src/ui/tabpopup.c: put in a hack to make the build temporarily
	work, want to commit the large rearrangement before fixing this
	not to include workspace.h or frame.h

	* src/core/iconcache.c (meta_read_icons): temporarily break this
	to get the build to work, want to commit the large rearrangement
	before fixing this file not to include theme.h


svn path=/trunk/; revision=3491

ChangeLog

@@ -1,3 +1,22 @@
+2007-12-19  Havoc Pennington  <hp@redhat.com>
+
+	* src/ui, src/core, src/include: sort source files into these
+	directories according to which part of the WM they are supposed to
+	be in. In an eventual plan, we should also create
+	src/compositor/render, src/compositor/fallback and move some of
+	the compositor stuff into that.
+	
+	* autogen.sh: require a newer automake, so we don't have to use
+	a recursive build
+
+	* src/ui/tabpopup.c: put in a hack to make the build temporarily
+	work, want to commit the large rearrangement before fixing this
+	not to include workspace.h or frame.h
+
+	* src/core/iconcache.c (meta_read_icons): temporarily break this
+	to get the build to work, want to commit the large rearrangement
+	before fixing this file not to include theme.h
+
 2007-12-19  Thomas Thurman  <thomas@thurman.org.uk>
 
         * configure.in: Post-release bump to 2.21.8.

autogen.sh

@@ -5,7 +5,7 @@ srcdir=`dirname $0`
 test -z "$srcdir" && srcdir=.
 
 PKG_NAME="metacity"
-REQUIRED_AUTOMAKE_VERSION=1.7
+REQUIRED_AUTOMAKE_VERSION=1.10
 
 (test -f $srcdir/configure.in \
   && test -d $srcdir/src) || {

configure.in

@@ -11,7 +11,7 @@ m4_define([metacity_version],
 AC_INIT([metacity], [metacity_version],
         [http://bugzilla.gnome.org/enter_bug.cgi?product=metacity])
 
-AC_CONFIG_SRCDIR(src/display.c)
+AC_CONFIG_SRCDIR(src/core/display.c)
 AC_CONFIG_HEADERS(config.h)
 
 AM_INIT_AUTOMAKE

src/Makefile.am

@@ -2,112 +2,112 @@ lib_LTLIBRARIES = libmetacity-private.la
 
 SUBDIRS=wm-tester tools themes
 
-INCLUDES=@METACITY_CFLAGS@ -DMETACITY_LIBEXECDIR=\"$(libexecdir)\" -DHOST_ALIAS=\"@HOST_ALIAS@\" -DMETACITY_LOCALEDIR=\"$(prefix)/@DATADIRNAME@/locale\" -DMETACITY_PKGDATADIR=\"$(pkgdatadir)\" -DMETACITY_DATADIR=\"$(datadir)\" -DG_LOG_DOMAIN=\"metacity\" -DSN_API_NOT_YET_FROZEN=1
+INCLUDES=@METACITY_CFLAGS@ -I $(srcdir)/include -DMETACITY_LIBEXECDIR=\"$(libexecdir)\" -DHOST_ALIAS=\"@HOST_ALIAS@\" -DMETACITY_LOCALEDIR=\"$(prefix)/@DATADIRNAME@/locale\" -DMETACITY_PKGDATADIR=\"$(pkgdatadir)\" -DMETACITY_DATADIR=\"$(datadir)\" -DG_LOG_DOMAIN=\"metacity\" -DSN_API_NOT_YET_FROZEN=1
 
 metacity_SOURCES= 				\
-	async-getprop.c				\
+	core/async-getprop.c			\
-	async-getprop.h				\
+	core/async-getprop.h			\
-	bell.h					\
+	core/bell.c				\
-	bell.c					\
+	core/bell.h				\
-	boxes.h					\
+	core/boxes.c				\
-	boxes.c					\
+	include/boxes.h				\
-	common.h				\
+	core/compositor.c			\
-	compositor.c				\
+	core/compositor.h			\
-	compositor.h				\
+	core/constraints.c			\
-	constraints.c				\
+	core/constraints.h			\
-	constraints.h				\
+	core/core.c				\
-	core.c					\
+	core/delete.c				\
-	core.h					\
+	core/display.c				\
-	delete.c				\
+	core/display.h				\
-	display.c				\
+	ui/draw-workspace.c			\
-	display.h				\
+	core/draw-workspace.h			\
-	draw-workspace.c			\
+	core/edge-resistance.c			\
-	draw-workspace.h			\
+	core/edge-resistance.h			\
-	edge-resistance.c			\
+	core/effects.c				\
-	edge-resistance.h			\
+	core/effects.h				\
-	effects.c				\
+	core/errors.c				\
-	effects.h				\
+	core/errors.h				\
-	errors.c				\
+	core/eventqueue.c			\
-	errors.h				\
+	core/eventqueue.h			\
-	eventqueue.c				\
+	core/frame.c				\
-	eventqueue.h				\
+	core/frame.h				\
-	fixedtip.c				\
+	ui/gradient.c				\
-	fixedtip.h				\
+	ui/gradient.h				\
-	frame.c					\
+	core/group-private.h			\
-	frame.h					\
+	core/group-props.c			\
-	frames.c				\
+	core/group-props.h			\
-	frames.h				\
+	core/group.c				\
-	gradient.c				\
+	core/group.h				\
-	gradient.h				\
+	core/iconcache.c			\
-	group.c					\
+	core/iconcache.h			\
-	group.h					\
+	core/keybindings.c			\
-	group-private.h				\
+	core/keybindings.h			\
-	group-props.c				\
+	core/main.c				\
-	group-props.h				\
+	core/main.h				\
-	iconcache.c				\
+	core/metacity-Xatomtype.h		\
-	iconcache.h				\
+	core/place.c				\
+	core/place.h				\
+	core/prefs.c				\
+	core/prefs.h				\
+	core/screen.c				\
+	core/screen.h				\
+	core/session.c				\
+	core/session.h				\
+	core/spring-model.c			\
+	core/spring-model.h			\
+	core/stack.c				\
+	core/stack.h				\
+	core/util.c				\
+	include/util.h				\
+	core/window-props.c			\
+	core/window-props.h			\
+	core/window.c				\
+	core/window.h				\
+	core/workspace.c			\
+	core/workspace.h			\
+	core/xprops.c				\
+	core/xprops.h				\
+	include/common.h			\
+	include/core.h				\
+	include/ui.h				\
 	inlinepixbufs.h				\
-	keybindings.c				\
+	ui/fixedtip.c				\
-	keybindings.h				\
+	ui/fixedtip.h				\
-	main.c					\
+	ui/frames.c				\
-	main.h					\
+	ui/frames.h				\
-	menu.c					\
+	ui/menu.c				\
-	menu.h					\
+	ui/menu.h				\
-	metaaccellabel.c			\
+	ui/metaaccellabel.c			\
-	metaaccellabel.h			\
+	ui/metaaccellabel.h			\
-	metacity-Xatomtype.h			\
+	ui/resizepopup.c			\
-	place.c					\
+	include/resizepopup.h			\
-	place.h					\
+	ui/tabpopup.c				\
-	prefs.c					\
+	include/tabpopup.h				\
-	prefs.h					\
+	ui/theme-parser.c			\
-	resizepopup.c				\
+	ui/theme-parser.h			\
-	resizepopup.h				\
+	ui/theme.c				\
-	screen.c				\
+	ui/theme.h				\
-	screen.h				\
+	ui/themewidget.c			\
-	session.c				\
+	ui/themewidget.h			\
-	session.h				\
+	ui/ui.c
-	spring-model.c				\
-	spring-model.h				\
-	stack.c					\
-	stack.h					\
-	tabpopup.c				\
-	tabpopup.h				\
-	theme.c					\
-	theme.h					\
-	theme-parser.c				\
-	theme-parser.h				\
-	themewidget.c				\
-	themewidget.h				\
-	ui.c					\
-	ui.h					\
-	util.c					\
-	util.h					\
-	window.c				\
-	window.h				\
-	window-props.c				\
-	window-props.h				\
-	workspace.c				\
-	workspace.h				\
-	xprops.c				\
-	xprops.h
 
 # by setting libmetacity_private_la_CFLAGS, the files shared with
 # metacity proper will be compiled with different names.
 libmetacity_private_la_CFLAGS =
 libmetacity_private_la_SOURCES=			\
-	boxes.c			\
+	core/boxes.c				\
-	boxes.h			\
+	include/boxes.h				\
-	gradient.c		\
+	ui/gradient.c				\
-	gradient.h		\
+	ui/gradient.h				\
-	preview-widget.c	\
+	core/util.c				\
-	preview-widget.h	\
+	include/util.h				\
-	theme.c			\
+	include/common.h			\
-	theme.h			\
+	ui/preview-widget.c			\
-	theme-parser.c		\
+	ui/preview-widget.h			\
-	theme-parser.h		\
+	ui/theme-parser.c			\
-	util.c			\
+	ui/theme-parser.h			\
-	util.h			\
+	ui/theme.c				\
-	common.h
+	ui/theme.h
 
 libmetacity_private_la_LDFLAGS = -no-undefined
 libmetacity_private_la_LIBADD  = @METACITY_LIBS@
@@ -115,19 +115,19 @@ libmetacity_private_la_LIBADD  = @METACITY_LIBS@
 libmetacityincludedir = $(includedir)/metacity-1/metacity-private
 
 libmetacityinclude_HEADERS =			\
-	boxes.h			\
+	include/boxes.h				\
-	common.h		\
+	ui/gradient.h				\
-	gradient.h		\
+	include/util.h				\
-	preview-widget.h	\
+	include/common.h			\
-	theme.h			\
+	ui/preview-widget.h			\
-	theme-parser.h		\
+	ui/theme-parser.h			\
-	util.h
+	ui/theme.h
 
 metacity_theme_viewer_SOURCES=  \
-	theme-viewer.c
+	ui/theme-viewer.c
 
 metacity_dialog_SOURCES= 	\
-	metacity-dialog.c
+	ui/metacity-dialog.c
 
 bin_PROGRAMS=metacity metacity-theme-viewer
 libexec_PROGRAMS=metacity-dialog
@@ -137,9 +137,9 @@ metacity_LDADD=@METACITY_LIBS@ $(EFENCE)
 metacity_theme_viewer_LDADD= @METACITY_LIBS@ libmetacity-private.la
 metacity_dialog_LDADD=@METACITY_LIBS@
 
-testboxes_SOURCES=util.h util.c boxes.h boxes.c testboxes.c
+testboxes_SOURCES=include/util.h core/util.c include/boxes.h core/boxes.c core/testboxes.c
-testgradient_SOURCES=gradient.h gradient.c testgradient.c
+testgradient_SOURCES=ui/gradient.h ui/gradient.c ui/testgradient.c
-testasyncgetprop_SOURCES=async-getprop.h async-getprop.c testasyncgetprop.c
+testasyncgetprop_SOURCES=core/async-getprop.h core/async-getprop.c core/testasyncgetprop.c
 
 noinst_PROGRAMS=testboxes testgradient testasyncgetprop
 

src/core/iconcache.c

@@ -25,7 +25,6 @@
 #include "iconcache.h"
 #include "ui.h"
 #include "errors.h"
-#include "theme.h"
 
 #include <X11/Xatom.h>
 
@@ -818,6 +817,8 @@ meta_read_icons (MetaScreen     *screen,
   if (icon_cache->want_fallback &&
       icon_cache->origin < USING_FALLBACK_ICON)
     {
+#if 0
+      /* FIXME this code requires GTK and thus does not belong here in core/ */
       MetaTheme *theme = meta_theme_get_current ();
 
       if (theme->fallback_icon == NULL || theme->fallback_mini_icon == NULL)
@@ -840,6 +841,9 @@ meta_read_icons (MetaScreen     *screen,
                      *iconp, *mini_iconp);
 
       return TRUE;
+#else
+      return FALSE;
+#endif
     }
 
   if (!icon_cache->want_fallback &&

src/ui/frames.c

@@ -33,7 +33,6 @@
 #include "fixedtip.h"
 #include "theme.h"
 #include "prefs.h"
-#include "errors.h"
 #include "ui.h"
 
 #ifdef HAVE_SHAPE

src/ui/tabpopup.c

@@ -28,9 +28,11 @@
 #include "util.h"
 #include "core.h"
 #include "tabpopup.h"
-#include "workspace.h" /* FIXME should not be included in this file */
+/* FIXME these two includes are 100% broken ...
+ */
+#include "../core/workspace.h"
+#include "../core/frame.h"
 #include "draw-workspace.h"
-#include "frame.h"
 #include <gtk/gtk.h>
 #include <math.h>