isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-12-23 11:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "renderer-native: Actually use shadow fb when using software rendering"

Browse Source 
It was not the lack of forcing the shadow fb that caused slowness, but
rather due to the method the shadow fb content was copied onto the
scanout fb. With 'clutter: Use cogl_blit_framebuffer() for shadow FB'
we'll use a path that shouldn't be slow when copying onto the scanout
fb.

Also 437f6b3d59 accidentally enabled
shadow fb when using hw accelerated contexts, due to the cap being set
to 1 in majority of drivers. While the kernel documentation for the
related field says "hint to userspace to prefer shadow-fb rendering",
the name of the hint when exposed to userspace is
DRM_CAP_DUMB_PREFER_SHADOW, thus should only be taken into consideration
for dumb buffers, not rendering in general.

This reverts commit 437f6b3d59.

https://gitlab.gnome.org/GNOME/mutter/merge_requests/818
This commit is contained in:
Jonas Ådahl 2019-09-30 11:21:36 +02:00
parent 0f51ae7cf0
commit 7049b2f274
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backends/native/meta-renderer-native.c
View File

@ -3213,11 +3213,11 @@ should_force_shadow_fb (MetaRendererNative *renderer_native,
case COGL_GPU_INFO_ARCHITECTURE_SANDYBRIDGE: case COGL_GPU_INFO_ARCHITECTURE_SANDYBRIDGE:
case COGL_GPU_INFO_ARCHITECTURE_SGX: case COGL_GPU_INFO_ARCHITECTURE_SGX:
case COGL_GPU_INFO_ARCHITECTURE_MALI: case COGL_GPU_INFO_ARCHITECTURE_MALI:
break; return FALSE;
case COGL_GPU_INFO_ARCHITECTURE_LLVMPIPE: case COGL_GPU_INFO_ARCHITECTURE_LLVMPIPE:
case COGL_GPU_INFO_ARCHITECTURE_SOFTPIPE: case COGL_GPU_INFO_ARCHITECTURE_SOFTPIPE:
case COGL_GPU_INFO_ARCHITECTURE_SWRAST: case COGL_GPU_INFO_ARCHITECTURE_SWRAST:
return TRUE; break;
} }
kms_fd = meta_gpu_kms_get_fd (primary_gpu); kms_fd = meta_gpu_kms_get_fd (primary_gpu);