isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-02 14:53:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

meta_workspace_set_builtin_struts(): optimize out non-changes

Browse Source 
meta_workspace_set_builtin_struts() is slightly expensive; it involves
discarding all our cached computed information about the layout of the
workspace. So catch calls to set_builtin_struts() that don't change
anything.

https://bugzilla.gnome.org/show_bug.cgi?id=609546
This commit is contained in:
Owen W. Taylor 2010-02-10 09:48:46 -05:00
parent 2a823ef3e4
commit 6ffe5f8343
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/core/workspace.c
View File

@ -959,6 +959,23 @@ ensure_work_areas_validated (MetaWorkspace *workspace)
} }
} }
static gboolean
strut_lists_equal (GSList *l,
GSList *m)
{
for (; l && m; l = l->next, m = m->next)
{
MetaStrut *a = l->data;
MetaStrut *b = m->data;
if (a->side != b->side ||
!meta_rectangle_equal (&a->rect, &b->rect))
return FALSE;
}
return l == NULL && m == NULL;
}
/** /**
* meta_workspace_set_builtin_struts: * meta_workspace_set_builtin_struts:
* @workspace: a #MetaWorkspace * @workspace: a #MetaWorkspace
@ -972,6 +989,12 @@ void
meta_workspace_set_builtin_struts (MetaWorkspace *workspace, meta_workspace_set_builtin_struts (MetaWorkspace *workspace,
GSList *struts) GSList *struts)
{ {
/* Reordering doesn't actually matter, so we don't catch all
* no-impact changes, but this is just a (possibly unnecessary
* anyways) optimization */
if (strut_lists_equal (struts, workspace->builtin_struts))
return;
workspace_free_builtin_struts (workspace); workspace_free_builtin_struts (workspace);
workspace->builtin_struts = copy_strut_list (struts); workspace->builtin_struts = copy_strut_list (struts);