isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-26 18:11:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

wayland/xdg-shell: Ignore reposition if popup was dismissed

Browse Source 
If the popup was dismissed (i.e. has no MetaWindow anymore), it'll also
have no parent surface. With no parent surface, we'd try to fetch a
transaction from NULL and crash, but if we don't try if we were
dismissed, we won't reach here anyway.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2940>
This commit is contained in:
Jonas Ådahl 2023-03-27 21:36:19 +02:00
parent f744acefee
commit 697b99ee13
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wayland/meta-wayland-xdg-shell.c
View File

@ -642,6 +642,9 @@ xdg_popup_reposition (struct wl_client *client,
MetaWaylandXdgPositioner *xdg_positioner; MetaWaylandXdgPositioner *xdg_positioner;
MetaWaylandTransaction *transaction; MetaWaylandTransaction *transaction;
if (!meta_wayland_surface_get_window (surface))
return;
xdg_positioner = g_memdup2 (wl_resource_get_user_data (positioner_resource), xdg_positioner = g_memdup2 (wl_resource_get_user_data (positioner_resource),
sizeof (MetaWaylandXdgPositioner)); sizeof (MetaWaylandXdgPositioner));