From 6754195580228852fb95e6a42c5582d0d2660355 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Fri, 17 Apr 2020 10:12:33 +0200 Subject: [PATCH] clutter/script-parser: Don't skip construct parameters when constructing The script parser only included G_PARAM_CONSTRUCT_ONLY parameters when constructing objects. This causes issues if an object requires a parameter to be set during construction, but may also change after. Fix this by including G_PARAM_CONSTRUCT parameters when constructing script objects as well. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1289 --- clutter/clutter/clutter-script-parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clutter/clutter/clutter-script-parser.c b/clutter/clutter/clutter-script-parser.c index bf3d51878..0de445795 100644 --- a/clutter/clutter/clutter-script-parser.c +++ b/clutter/clutter/clutter-script-parser.c @@ -1523,7 +1523,7 @@ clutter_script_construct_parameters (ClutterScript *script, continue; } - if (!(pspec->flags & G_PARAM_CONSTRUCT_ONLY)) + if (!(pspec->flags & (G_PARAM_CONSTRUCT | G_PARAM_CONSTRUCT_ONLY))) { unparsed = g_list_prepend (unparsed, pinfo); continue;