isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-12-23 19:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

window: Move all attached windows with parent

Browse Source 
We'd break the loop for moving attached windows at the first window,
meaning we'd only ever move a single attached dialogs or popup if it was
the first window in the list. This doesn't work out well when there are
multiple popups open, so don't break out of the loop at all until all
windows are potentially moved.

This fixes an issue in gtk4 where one or more non-grabbing popups would
end up unattached if there were more than one and the parent window was
moved.

https://gitlab.gnome.org/GNOME/mutter/merge_requests/592
This commit is contained in:
Jonas Ådahl 2019-05-24 10:52:40 +02:00 committed by Florian Müllner
parent b01edc22f3
commit 439afb3f19
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/window.c
View File

@ -3812,13 +3812,13 @@ maybe_move_attached_window (MetaWindow *window,
void *data) void *data)
{ {
if (window->hidden) if (window->hidden)
return FALSE; return G_SOURCE_CONTINUE;
if (meta_window_is_attached_dialog (window) || if (meta_window_is_attached_dialog (window) ||
meta_window_get_placement_rule (window)) meta_window_get_placement_rule (window))
meta_window_reposition (window); meta_window_reposition (window);
return FALSE; return G_SOURCE_CONTINUE;
} }
/** /**