isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-08-06 00:24:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

display: Ignore the modmask passed into meta_display_begin_grab_op

Browse Source 
A careful analysis of mutter's codebase shows that nothing actually
passes anything but 0 to this. gnome-shell has one instance, but it's
most likely a mistake.

Remove the grab_mask field and the one place in keybindings.c that uses it.

The parameter to begin_grab_op is left in for API compatibility reasons.
This commit is contained in:
Jasper St. Pierre
2014-04-07 17:22:55 -04:00
parent b0ea0afd2f
commit 42bcad6549
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/display.c
View File

@@ -1867,7 +1867,7 @@ meta_display_begin_grab_op (MetaDisplay *display,
gboolean pointer_already_grabbed,
gboolean frame_action,
int button,
gulong modmask,
gulong modmask, /* XXX - ignored */
guint32 timestamp,
int root_x,
int root_y)
@@ -1962,7 +1962,6 @@ meta_display_begin_grab_op (MetaDisplay *display,
display->grab_window = grab_window;
display->grab_xwindow = grab_xwindow;
display->grab_button = button;
display->grab_mask = modmask;
if (window)
{
display->grab_tile_mode = window->tile_mode;