From 2aaed7bdfc0d6a38f80afea3d9f09f560a177570 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Fri, 8 Mar 2019 15:33:39 -0500 Subject: [PATCH] cogl: Remove debug disables for GLSL and NPOT textures https://gitlab.gnome.org/GNOME/mutter/merge_requests/546 --- cogl/cogl/cogl-context.c | 24 ------------------------ cogl/cogl/cogl-debug-options.h | 11 ----------- cogl/cogl/cogl-debug.c | 2 -- cogl/cogl/cogl-debug.h | 2 -- 4 files changed, 39 deletions(-) diff --git a/cogl/cogl/cogl-context.c b/cogl/cogl/cogl-context.c index 7dffad2df..b5535d8f1 100644 --- a/cogl/cogl/cogl-context.c +++ b/cogl/cogl/cogl-context.c @@ -105,30 +105,6 @@ _cogl_init_feature_overrides (CoglContext *ctx) if (G_UNLIKELY (COGL_DEBUG_ENABLED (COGL_DEBUG_DISABLE_PBOS))) COGL_FLAGS_SET (ctx->private_features, COGL_PRIVATE_FEATURE_PBOS, FALSE); - - if (G_UNLIKELY (COGL_DEBUG_ENABLED (COGL_DEBUG_DISABLE_GLSL))) - { - ctx->feature_flags &= ~COGL_FEATURE_SHADERS_GLSL; - COGL_FLAGS_SET (ctx->features, COGL_FEATURE_ID_GLSL, FALSE); - COGL_FLAGS_SET (ctx->features, - COGL_FEATURE_ID_PER_VERTEX_POINT_SIZE, - FALSE); - } - - if (G_UNLIKELY (COGL_DEBUG_ENABLED (COGL_DEBUG_DISABLE_NPOT_TEXTURES))) - { - ctx->feature_flags &= ~(COGL_FEATURE_TEXTURE_NPOT | - COGL_FEATURE_TEXTURE_NPOT_BASIC | - COGL_FEATURE_TEXTURE_NPOT_MIPMAP | - COGL_FEATURE_TEXTURE_NPOT_REPEAT); - COGL_FLAGS_SET (ctx->features, COGL_FEATURE_ID_TEXTURE_NPOT, FALSE); - COGL_FLAGS_SET (ctx->features, - COGL_FEATURE_ID_TEXTURE_NPOT_BASIC, FALSE); - COGL_FLAGS_SET (ctx->features, - COGL_FEATURE_ID_TEXTURE_NPOT_MIPMAP, FALSE); - COGL_FLAGS_SET (ctx->features, - COGL_FEATURE_ID_TEXTURE_NPOT_REPEAT, FALSE); - } } const CoglWinsysVtable * diff --git a/cogl/cogl/cogl-debug-options.h b/cogl/cogl/cogl-debug-options.h index 9e328d7e0..ec0ca6b82 100644 --- a/cogl/cogl/cogl-debug-options.h +++ b/cogl/cogl/cogl-debug-options.h @@ -130,22 +130,11 @@ OPT (DISABLE_TEXTURING, "disable-texturing", N_("Disable texturing"), N_("Disable texturing any primitives")) -OPT (DISABLE_GLSL, - N_("Root Cause"), - "disable-glsl", - N_("Disable GLSL"), - N_("Disable use of GLSL")) OPT (DISABLE_BLENDING, N_("Root Cause"), "disable-blending", N_("Disable blending"), N_("Disable use of blending")) -OPT (DISABLE_NPOT_TEXTURES, - N_("Root Cause"), - "disable-npot-textures", - N_("Disable non-power-of-two textures"), - N_("Makes Cogl think that the GL driver doesn't support NPOT textures " - "so that it will create sliced textures or textures with waste instead.")) OPT (DISABLE_SOFTWARE_CLIP, N_("Root Cause"), "disable-software-clip", diff --git a/cogl/cogl/cogl-debug.c b/cogl/cogl/cogl-debug.c index cc98b6853..843f7cbe1 100644 --- a/cogl/cogl/cogl-debug.c +++ b/cogl/cogl/cogl-debug.c @@ -77,9 +77,7 @@ static const GDebugKey cogl_behavioural_debug_keys[] = { { "disable-atlas", COGL_DEBUG_DISABLE_ATLAS }, { "disable-shared-atlas", COGL_DEBUG_DISABLE_SHARED_ATLAS }, { "disable-texturing", COGL_DEBUG_DISABLE_TEXTURING}, - { "disable-glsl", COGL_DEBUG_DISABLE_GLSL}, { "disable-blending", COGL_DEBUG_DISABLE_BLENDING}, - { "disable-npot-textures", COGL_DEBUG_DISABLE_NPOT_TEXTURES}, { "wireframe", COGL_DEBUG_WIREFRAME}, { "disable-software-clip", COGL_DEBUG_DISABLE_SOFTWARE_CLIP}, { "disable-program-caches", COGL_DEBUG_DISABLE_PROGRAM_CACHES}, diff --git a/cogl/cogl/cogl-debug.h b/cogl/cogl/cogl-debug.h index 6f0eb36fc..17a8f8764 100644 --- a/cogl/cogl/cogl-debug.h +++ b/cogl/cogl/cogl-debug.h @@ -61,12 +61,10 @@ typedef enum COGL_DEBUG_DISABLE_SHARED_ATLAS, COGL_DEBUG_OPENGL, COGL_DEBUG_DISABLE_TEXTURING, - COGL_DEBUG_DISABLE_GLSL, COGL_DEBUG_SHOW_SOURCE, COGL_DEBUG_DISABLE_BLENDING, COGL_DEBUG_TEXTURE_PIXMAP, COGL_DEBUG_BITMAP, - COGL_DEBUG_DISABLE_NPOT_TEXTURES, COGL_DEBUG_WIREFRAME, COGL_DEBUG_DISABLE_SOFTWARE_CLIP, COGL_DEBUG_DISABLE_PROGRAM_CACHES,