isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-23 00:20:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

[group] avoid double evaluation of arguments in clutter_group_add

Browse Source 
clutter_group_add would evaluate the actor argument twice, which is
bad if this is a function call creating a new actor and not a variable.
This commit is contained in:
Øyvind Kolås 2009-04-08 18:18:31 +01:00
parent a9f24351e9
commit 269598a2cf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clutter/clutter-group.h
View File

@ -106,10 +106,10 @@ void clutter_group_remove_all (ClutterGroup *group);
/* for Mr. Mallum */ /* for Mr. Mallum */
#define clutter_group_add(group,actor) G_STMT_START { \ #define clutter_group_add(group,actor) G_STMT_START { \
if (CLUTTER_IS_GROUP ((group)) && CLUTTER_IS_ACTOR ((actor))) \ ClutterActor *_actor = (ClutterActor *) (actor); \
if (CLUTTER_IS_GROUP ((group)) && CLUTTER_IS_ACTOR ((_actor))) \
{ \ { \
ClutterContainer *_container = (ClutterContainer *) (group); \ ClutterContainer *_container = (ClutterContainer *) (group); \
ClutterActor *_actor = (ClutterActor *) (actor); \
clutter_container_add_actor (_container, _actor); \ clutter_container_add_actor (_container, _actor); \
} } G_STMT_END } } G_STMT_END