isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-22 16:10:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

tests: Don't check pixels outside actor allocation

Browse Source 
The actor-shader-effect test actors are 50px wide, but we check the 51st
pixel. This went along undetected until "clutter: Avoid rounding
compensation when invalidating 2D actors" because the paint volumes were
made slightly bigger and the shaders paint all over them (I guess nobody
noticed those actors being actually ~52px wide).

Update the test to check the middle of the opposite edge, so we keep neatly
rounded numbers.
This commit is contained in:
Carlos Garnacho 2018-12-18 13:54:09 +01:00
parent 697aeae2ad
commit 1d73533f78
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clutter/tests/conform/actor-shader-effect.c
View File

@ -230,13 +230,13 @@ paint_cb (ClutterStage *stage,
gboolean *was_painted = data; gboolean *was_painted = data;
/* old shader effect */ /* old shader effect */
g_assert_cmpint (get_pixel (50, 50), ==, 0xff0000); g_assert_cmpint (get_pixel (0, 25), ==, 0xff0000);
/* new shader effect */ /* new shader effect */
g_assert_cmpint (get_pixel (150, 50), ==, 0x00ffff); g_assert_cmpint (get_pixel (100, 25), ==, 0x00ffff);
/* another new shader effect */ /* another new shader effect */
g_assert_cmpint (get_pixel (250, 50), ==, 0xff00ff); g_assert_cmpint (get_pixel (200, 25), ==, 0xff00ff);
/* new shader effect */ /* new shader effect */
g_assert_cmpint (get_pixel (350, 50), ==, 0x00ffff); g_assert_cmpint (get_pixel (300, 25), ==, 0x00ffff);
*was_painted = TRUE; *was_painted = TRUE;
} }