From 176ac7e25b26f36a59d64f289cd2cbbf157a7796 Mon Sep 17 00:00:00 2001 From: Robert Bragg Date: Mon, 2 Sep 2013 14:26:03 +0100 Subject: [PATCH] tests: use 'FIXME' instead of 'fail' for expected failures Seeing 'fail' in the test reports and the explanation that it means "Test failed, but it was an expected failure" somewhat gives the impression that these failures are ok. Actually these failures represent known bugs/issues that we haven't yet fixed but we don't want them to result in 'make check' ailing. To try and better reflect the severity of these issues we now report them as 'FIXME'. Reviewed-by: Neil Roberts (cherry picked from commit 7934bf3ee4356af160b63084c7192fd2965b5ddd) --- tests/run-tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/run-tests.sh b/tests/run-tests.sh index 388fa036c..7e62bf0f6 100755 --- a/tests/run-tests.sh +++ b/tests/run-tests.sh @@ -31,7 +31,7 @@ echo "Key:" echo "ok = Test passed" echo "n/a = Driver is missing a feature required for the test" echo "FAIL = Unexpected failure" -echo "fail = Test failed, but it was an expected failure" +echo "FIXME = Test failed, but it was an expected failure" echo "PASS! = Unexpected pass" echo "" @@ -42,7 +42,7 @@ get_status() # but it was an expected failure so don't fail the # overall test run as a result... 300) - echo -n "fail";; + echo -n "FIXME";; # Special value we use to indicate that the test passed # but we weren't expecting it to pass‽ 400)