isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-02-16 13:24:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Raise the ancestor of a window instead of the window itself. Fixes

Browse Source 
2005-02-12  Elijah Newren  <newren@gmail.com>

	Raise the ancestor of a window instead of the window itself.
	Fixes #166894.

	* src/window.c: (find_root_ancestor): new function,
	(meta_window_raise): get the ancestor of the given window and
	raise it if possible instead of the window
This commit is contained in:
Elijah Newren 2005-02-12 07:34:30 +00:00 committed by Elijah Newren
parent 9fa5c1d4b9
commit 0488efc8c1
2 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,12 @@
2005-02-12 Elijah Newren <newren@gmail.com>
Raise the ancestor of a window instead of the window itself.
Fixes #166894.
* src/window.c: (find_root_ancestor): new function,
(meta_window_raise): get the ancestor of the given window and
raise it if possible instead of the window
2005-02-12 Elijah Newren <newren@gmail.com> 2005-02-12 Elijah Newren <newren@gmail.com>
Don't unconditionally place splashscreens (and other Don't unconditionally place splashscreens (and other

37
src/window.c
View File

@ -3654,13 +3654,44 @@ meta_window_set_current_workspace_hint (MetaWindow *window)
meta_error_trap_pop (window->display, FALSE); meta_error_trap_pop (window->display, FALSE);
} }
static gboolean
find_root_ancestor (MetaWindow *window,
void *data)
{
MetaWindow **ancestor = data;
/* Overwrite the previously "most-root" ancestor with the new one found */
*ancestor = window;
/* We want this to continue until meta_window_foreach_ancestor quits because
* there are no more valid ancestors.
*/
return TRUE;
}
void void
meta_window_raise (MetaWindow *window) meta_window_raise (MetaWindow *window)
{ {
meta_topic (META_DEBUG_WINDOW_OPS, MetaWindow *ancestor;
"Raising window %s\n", window->desc); ancestor = window;
meta_window_foreach_ancestor (window, find_root_ancestor, &ancestor);
meta_stack_raise (window->screen->stack, window); meta_topic (META_DEBUG_WINDOW_OPS,
"Raising window %s, ancestor of %s\n",
ancestor->desc, window->desc);
if (window->screen->stack != ancestor->screen->stack)
{
meta_warning (
"Either stacks aren't per screen or some window has a weird "
"transient_for hint; window->screen->stack != "
"ancestor->screen->stack. window = %s, ancestor = %s.\n",
window->desc, ancestor->desc);
/* Just punt and raise the window itself */
meta_stack_raise (window->screen->stack, window);
}
else
meta_stack_raise (window->screen->stack, ancestor);
} }
void void