isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-27 10:30:47 -05:00
Code Issues Packages Projects Releases Wiki Activity
be2a1d85a5
mutter/src/wayland/meta-wayland-window-configuration.h

76 lines
2.9 KiB
C
Raw Normal View History

wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
/*
* Copyright (C) 2019 Red Hat
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
*/
#ifndef META_WAYLAND_WINDOW_CONFIGURATION_H
#define META_WAYLAND_WINDOW_CONFIGURATION_H
#include <glib.h>
#include <stdint.h>
wayland/window-configuration: Track resize flags and gravity too Will later be used to determine in what way a pending configuration will resize. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-14 03:55:00 -05:00
#include "core/window-private.h"
wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
#include "wayland/meta-wayland-types.h"
struct _MetaWaylandWindowConfiguration
{
uint32_t serial;
gboolean has_position;
int x;
int y;
wayland/window: Pass popup configuration using relative coordinates After popup placement rules have gone through the constraints engine has ended up resulting in an actual move, pass the window configuration down the path using relative coordinates, as that is what the next layer (xdg-shell implementation) actually cares about. In the future, this will also be helpful when the configured position is not against the current state of the parent. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-13 16:20:15 -05:00
gboolean has_relative_position;
int rel_x;
int rel_y;
wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
gboolean has_size;
window/wayland: Always include a size when sending a configuration Prior to 67033b0a mutter was accidentally including sizes for configurations that were just focus state changes. This was not leading to any known problems on the client side, but it was causing issues in mutter itself when detecting whether a resize originated from the client or the server. Not including sizes in focus change configurations anymore however revealed a bug in gtk. It was storing the window size when in a fixed size mode (tiled/maximized/fullscreen), but not on any other server side resizes. It was then restoring this stored size whenever there was a new configuration without a size while in floating mode, i.e. the focus change configurations generated by mutter after 67033b0a. This change now addresses the issue 67033b0a was fixing in a way that restores the previous behavior of always including the size whenever sending a configuration. Fixes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2091 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2238>
2022-01-15 19:44:37 -05:00
gboolean is_resizing;
wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
int width;
int height;
wayland/window-configuration: Track resize flags and gravity too Will later be used to determine in what way a pending configuration will resize. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-14 03:55:00 -05:00
wayland/window: Don't lose precision in MetaWaylandWindowConfiguration Commit 8bdd2aa7 would offset the window position by the difference between the configured window size and the committed size from the client to prevent the window from drifting while resizing. This, however, did not take into account the actual geometry scale, so when using any scale greater than 1, the window would rapidly drift away due to that offset. In order to solve this, we need to make sure we store away the pending window configuration in the stage coordinate space, in order to not loose precision. When we then calculate the offset given the result from the client, it'll use the right scalars, while before, one scalar was in surface coordinates, while the other in stage coordinates. https://gitlab.gnome.org/GNOME/mutter/-/issues/1490
2020-10-29 05:11:15 -04:00
int scale;
wayland/window-configuration: Track resize flags and gravity too Will later be used to determine in what way a pending configuration will resize. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-14 03:55:00 -05:00
MetaGravity gravity;
MetaMoveResizeFlags flags;
wayland/xdg-shell: Add toplevel bounds support This implements the new 'bounds' event that is part of the xdg_toplevel interface in the xdg-shell protocol. It aims to let clients create "good" default window sizes that depends on e.g. the resolution of the monitor the window will be mapped on, whether there are panels taking up space, and things like that. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2167>
2021-12-17 18:15:56 -05:00
int bounds_width;
int bounds_height;
wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
};
wayland: Only use async configured geometry if actually changed When (un)maximizing, (un)fullscreening, the move/resize action is flagged with 'ACTION_MOVE' and 'ACTION_RESIZE' , while e.g. 'appears-focus' does not. When a client misbehaved and didn't immediately reply to a configure request with a commit with the corresponding ack_configure, the following commit would trigger a oddly timed move, making the window appear to move back to a previous position. Avoid this issue by only carrying over the target window position if the configuration actually contained a new position. We cannot only rely on the flags however, as e.g. a new position should be respected during interactive resize, even though only 'ACTION_RESIZE' is passed in such scenarios. Do the same for the size, except if the window state dictates that the size is fixed to a certain size, e.g. being fullscreen or maximized. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1445>
2020-09-17 08:06:27 -04:00
MetaWaylandWindowConfiguration * meta_wayland_window_configuration_new (MetaWindow *window,
window/wayland: Pass x,y,width,height as rectangle Will make the number of variables a bit more managable. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2167>
2021-12-17 10:31:48 -05:00
MetaRectangle rect,
wayland/xdg-shell: Add toplevel bounds support This implements the new 'bounds' event that is part of the xdg_toplevel interface in the xdg-shell protocol. It aims to let clients create "good" default window sizes that depends on e.g. the resolution of the monitor the window will be mapped on, whether there are panels taking up space, and things like that. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2167>
2021-12-17 18:15:56 -05:00
int max_width,
int max_height,
wayland: Only use async configured geometry if actually changed When (un)maximizing, (un)fullscreening, the move/resize action is flagged with 'ACTION_MOVE' and 'ACTION_RESIZE' , while e.g. 'appears-focus' does not. When a client misbehaved and didn't immediately reply to a configure request with a commit with the corresponding ack_configure, the following commit would trigger a oddly timed move, making the window appear to move back to a previous position. Avoid this issue by only carrying over the target window position if the configuration actually contained a new position. We cannot only rely on the flags however, as e.g. a new position should be respected during interactive resize, even though only 'ACTION_RESIZE' is passed in such scenarios. Do the same for the size, except if the window state dictates that the size is fixed to a certain size, e.g. being fullscreen or maximized. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1445>
2020-09-17 08:06:27 -04:00
int scale,
MetaMoveResizeFlags flags,
MetaGravity gravity);
wayland/window: Pass popup configuration using relative coordinates After popup placement rules have gone through the constraints engine has ended up resulting in an actual move, pass the window configuration down the path using relative coordinates, as that is what the next layer (xdg-shell implementation) actually cares about. In the future, this will also be helpful when the configured position is not against the current state of the parent. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-13 16:20:15 -05:00
window/wayland: Always include a size when sending a configuration Prior to 67033b0a mutter was accidentally including sizes for configurations that were just focus state changes. This was not leading to any known problems on the client side, but it was causing issues in mutter itself when detecting whether a resize originated from the client or the server. Not including sizes in focus change configurations anymore however revealed a bug in gtk. It was storing the window size when in a fixed size mode (tiled/maximized/fullscreen), but not on any other server side resizes. It was then restoring this stored size whenever there was a new configuration without a size while in floating mode, i.e. the focus change configurations generated by mutter after 67033b0a. This change now addresses the issue 67033b0a was fixing in a way that restores the previous behavior of always including the size whenever sending a configuration. Fixes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2091 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2238>
2022-01-15 19:44:37 -05:00
MetaWaylandWindowConfiguration * meta_wayland_window_configuration_new_relative (MetaWindow *window,
int rel_x,
int rel_y,
int width,
int height,
int scale);
wayland/window: Pass popup configuration using relative coordinates After popup placement rules have gone through the constraints engine has ended up resulting in an actual move, pass the window configuration down the path using relative coordinates, as that is what the next layer (xdg-shell implementation) actually cares about. In the future, this will also be helpful when the configured position is not against the current state of the parent. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-13 16:20:15 -05:00
wayland/xdg-shell: Add toplevel bounds support This implements the new 'bounds' event that is part of the xdg_toplevel interface in the xdg-shell protocol. It aims to let clients create "good" default window sizes that depends on e.g. the resolution of the monitor the window will be mapped on, whether there are panels taking up space, and things like that. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2167>
2021-12-17 18:15:56 -05:00
MetaWaylandWindowConfiguration * meta_wayland_window_configuration_new_empty (int bounds_width,
int bounds_height);
wayland: Rework asynchronous window configuration This changes how asynchronous window configuration works. Prior to this commit, it worked by MetaWindowWayland remembering the last configuration it sent, then when the Wayland client got back to it, it tried to figure out whether it was a acknowledgment of the configuration or not, and finish the move. This failed if the client had acknowledged a configuration older than the last one sent, and it had hacks to somewhat deal with wl_shell's lack of configuration serial numbers. This commits scraps that and makes the MetaWindowWayland take ownership of sent configurations, including generating serial numbers. The wl_shell implementation is changed to emulate serial numbers (assuming each commit acknowledges the last sent configure event). Each configuration sent to the client is kept around until the client one. At this point, the position used for that particular configuration is used when applying the acknowledged state, meaning cases where we have already sent a new configuration when the client acknowledges a previous one, we'll still use the correct position for the window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 12:10:14 -04:00
void meta_wayland_window_configuration_free (MetaWaylandWindowConfiguration *configuration);
#endif /* META_WAYLAND_WINDOW_CONFIGURATION_H */
Reference in New Issue Copy Permalink