2006-10-01 22:30:10 +00:00
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2001-05-30 15:36:31 +00:00
/* Metacity utilities */
/*
* Copyright ( C ) 2001 Havoc Pennington
2005-10-08 19:38:54 +00:00
* Copyright ( C ) 2005 Elijah Newren
2001-05-30 15:36:31 +00:00
*
* This program is free software ; you can redistribute it and / or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation ; either version 2 of the
* License , or ( at your option ) any later version .
*
* This program is distributed in the hope that it will be useful , but
* WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the GNU
* General Public License for more details .
*
* You should have received a copy of the GNU General Public License
* along with this program ; if not , write to the Free Software
* Foundation , Inc . , 59 Temple Place - Suite 330 , Boston , MA
* 02111 - 1307 , USA .
*/
2008-02-27 04:39:10 +00:00
# define _GNU_SOURCE
2008-11-23 18:53:55 +00:00
# define _POSIX_C_SOURCE 200112L /* for fdopen() */
2008-02-27 04:39:10 +00:00
2002-03-05 02:43:22 +00:00
# include <config.h>
2001-05-30 15:36:31 +00:00
# include "util.h"
# include "main.h"
# include <stdio.h>
2001-05-31 03:30:58 +00:00
# include <stdlib.h>
2001-09-11 03:54:54 +00:00
# include <unistd.h>
2002-03-05 02:43:22 +00:00
# include <errno.h>
# include <string.h>
2006-01-13 21:36:10 +00:00
# include <X11/Xlib.h> /* must explicitly be included for Solaris; #326746 */
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
# include <X11/Xutil.h> /* Just for the definition of the various gravities */
2001-05-30 15:36:31 +00:00
2002-07-23 19:12:02 +00:00
# ifdef HAVE_BACKTRACE
# include <execinfo.h>
2002-10-27 03:03:32 +00:00
void
meta_print_backtrace ( void )
2002-07-23 19:12:02 +00:00
{
void * bt [ 500 ] ;
int bt_size ;
int i ;
char * * syms ;
bt_size = backtrace ( bt , 500 ) ;
syms = backtrace_symbols ( bt , bt_size ) ;
i = 0 ;
while ( i < bt_size )
{
meta_verbose ( " %s \n " , syms [ i ] ) ;
+ + i ;
}
free ( syms ) ;
}
# else
2002-10-27 03:03:32 +00:00
void
meta_print_backtrace ( void )
2002-07-23 19:12:02 +00:00
{
meta_verbose ( " Not compiled with backtrace support \n " ) ;
}
# endif
2001-05-31 06:42:58 +00:00
static gboolean is_verbose = FALSE ;
static gboolean is_debugging = FALSE ;
2002-06-08 23:55:27 +00:00
static gboolean replace_current = FALSE ;
2001-06-10 19:23:28 +00:00
static int no_prefix = 0 ;
2002-12-09 02:53:16 +00:00
# ifdef WITH_VERBOSE_MODE
2001-06-11 05:47:51 +00:00
static FILE * logfile = NULL ;
static void
ensure_logfile ( void )
{
2002-03-06 22:27:24 +00:00
if ( logfile = = NULL & & g_getenv ( " METACITY_USE_LOGFILE " ) )
2001-06-11 05:47:51 +00:00
{
2002-03-05 02:43:22 +00:00
char * filename = NULL ;
char * tmpl ;
int fd ;
GError * err ;
2001-06-11 05:47:51 +00:00
2002-03-05 02:43:22 +00:00
tmpl = g_strdup_printf ( " metacity-%d-debug-log-XXXXXX " ,
( int ) getpid ( ) ) ;
2001-09-11 02:57:05 +00:00
2002-03-05 02:43:22 +00:00
err = NULL ;
fd = g_file_open_tmp ( tmpl ,
& filename ,
& err ) ;
2001-06-11 05:47:51 +00:00
2002-03-05 02:43:22 +00:00
g_free ( tmpl ) ;
if ( err ! = NULL )
{
meta_warning ( _ ( " Failed to open debug log: %s \n " ) ,
err - > message ) ;
g_error_free ( err ) ;
return ;
}
logfile = fdopen ( fd , " w " ) ;
2001-06-11 05:47:51 +00:00
if ( logfile = = NULL )
2002-03-05 02:43:22 +00:00
{
meta_warning ( _ ( " Failed to fdopen() log file %s: %s \n " ) ,
filename , strerror ( errno ) ) ;
close ( fd ) ;
}
2001-06-11 05:47:51 +00:00
else
2002-03-05 02:43:22 +00:00
{
2002-12-08 19:17:17 +00:00
g_printerr ( _ ( " Opened log file %s \n " ) , filename ) ;
2002-03-05 02:43:22 +00:00
}
2001-06-11 05:47:51 +00:00
2002-03-05 02:43:22 +00:00
g_free ( filename ) ;
2001-06-11 05:47:51 +00:00
}
}
2002-12-09 02:53:16 +00:00
# endif
2001-05-30 15:36:31 +00:00
gboolean
meta_is_verbose ( void )
{
return is_verbose ;
}
void
meta_set_verbose ( gboolean setting )
{
2002-12-08 19:17:17 +00:00
# ifndef WITH_VERBOSE_MODE
if ( setting )
meta_fatal ( _ ( " Metacity was compiled without support for verbose mode \n " ) ) ;
2008-02-15 04:37:39 +00:00
# else
2001-06-11 05:47:51 +00:00
if ( setting )
ensure_logfile ( ) ;
2008-02-15 04:37:39 +00:00
# endif
2001-06-11 05:47:51 +00:00
2001-05-30 15:36:31 +00:00
is_verbose = setting ;
}
2001-05-31 06:42:58 +00:00
gboolean
meta_is_debugging ( void )
{
return is_debugging ;
}
void
meta_set_debugging ( gboolean setting )
{
2008-02-15 04:37:39 +00:00
# ifdef WITH_VERBOSE_MODE
2001-06-11 05:47:51 +00:00
if ( setting )
ensure_logfile ( ) ;
2008-02-15 04:37:39 +00:00
# endif
2001-05-31 06:42:58 +00:00
is_debugging = setting ;
}
2002-06-08 23:55:27 +00:00
gboolean
meta_get_replace_current_wm ( void )
{
return replace_current ;
}
void
meta_set_replace_current_wm ( gboolean setting )
{
replace_current = setting ;
}
2005-10-03 18:13:45 +00:00
char *
meta_g_utf8_strndup ( const gchar * src ,
gsize n )
{
const gchar * s = src ;
while ( n & & * s )
{
s = g_utf8_next_char ( s ) ;
n - - ;
}
return g_strndup ( src , s - src ) ;
}
2002-08-24 20:54:23 +00:00
static int
utf8_fputs ( const char * str ,
FILE * f )
{
char * l ;
2002-12-01 03:58:04 +00:00
int retval ;
2002-08-24 20:54:23 +00:00
l = g_locale_from_utf8 ( str , - 1 , NULL , NULL , NULL ) ;
if ( l = = NULL )
2002-12-01 03:58:04 +00:00
retval = fputs ( str , f ) ; /* just print it anyway, better than nothing */
2002-08-24 20:54:23 +00:00
else
2002-12-01 03:58:04 +00:00
retval = fputs ( l , f ) ;
2002-08-24 20:54:23 +00:00
g_free ( l ) ;
2002-12-01 03:58:04 +00:00
return retval ;
2002-08-24 20:54:23 +00:00
}
Patch from Carlo Wood to fix handling of unidirectional maximization and
2007-04-02 Elijah Newren <newren gmail com>
Patch from Carlo Wood to fix handling of unidirectional
maximization and partial struts. #358311.
* src/constraints.c (constrain_maximization):
determine target size for unidirectionally maximized windows by
determining how far they can be maximized without hitting
orthogonal struts. Avoids weird "empty spaces".
* src/boxes.[ch] (meta_rectangle_expand_to_avoiding_struts):
new function
2007-04-02 Elijah Newren <newren gmail com>
Make the strut lists (stored in workspaces) record both the
rectangle and the side that the strut is on. Lots of code
cleanups relating to struts.
* src/boxes.h (struct MetaStrut):
new struct for struts
* src/window.[ch] (struct MetaStruts, struct MetaWindow,
meta_window_update_struts):
overhaul to make window's struts remember their side as well as
their rectangular location, and just use a list instead of several
copies of near-identical code for left/right/top/bottom (allowing
us to nuke MetaStruts struct as well)
* src/testboxes.c (new_meta_strut, get_strut_list):
* src/workspace.c (ensure_work_areas_validated):
* src/boxes.c (meta_rectangle_get_minimal_spanning_set_for_region,
meta_rectangle_expand_to_avoiding_struts,
get_disjoint_strut_rect_list_in_region, fix_up_edges,
meta_rectangle_find_onscreen_edges,
meta_rectangle_find_nonintersected_xinerama_edges):
modify to handle struts being rectangle + side instead of just rectangle
* src/workspace.c (ensure_work_areas_validated):
simplify strut list creation considerably given MetaWindow change,
modify work_area computations to take advantage of region
computations being done (makes the code shorter as well as more
robust against pathological cases).
* src/util.[ch] (meta_free_gslist_and_elements):
new convenience function
* src/common.h (enum MetaDirection):
* src/edge-resistance.c (movement_towards_edge):
* src/boxes.c (meta_rectangle_edge_aligns,
rectangle_and_edge_intersection, split_edge):
Add more MetaDirection fields for convenience
* src/boxes.h (enum FixedDirections):
* src/constraints.c (setup_constraint_info, place_window_if_needed):
add a FIXED_DIRECTION_NONE to the FixedDirections enum to make
code more clear
svn path=/trunk/; revision=3144
2007-04-03 03:41:10 +00:00
void
meta_free_gslist_and_elements ( GSList * list_to_deep_free )
{
g_slist_foreach ( list_to_deep_free ,
( void ( * ) ( gpointer , gpointer ) ) & g_free , /* ew, for ugly */
NULL ) ;
g_slist_free ( list_to_deep_free ) ;
}
2002-12-08 19:17:17 +00:00
# ifdef WITH_VERBOSE_MODE
2001-05-30 15:36:31 +00:00
void
2002-12-08 19:17:17 +00:00
meta_debug_spew_real ( const char * format , . . . )
2001-05-30 15:36:31 +00:00
{
va_list args ;
gchar * str ;
2001-06-11 05:47:51 +00:00
FILE * out ;
2001-05-30 15:36:31 +00:00
g_return_if_fail ( format ! = NULL ) ;
2001-05-31 06:42:58 +00:00
if ( ! is_debugging )
2001-05-30 15:36:31 +00:00
return ;
va_start ( args , format ) ;
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
2001-06-11 05:47:51 +00:00
out = logfile ? logfile : stderr ;
2001-06-10 19:23:28 +00:00
if ( no_prefix = = 0 )
2002-08-24 20:54:23 +00:00
utf8_fputs ( _ ( " Window manager: " ) , out ) ;
utf8_fputs ( str , out ) ;
2001-06-21 06:08:35 +00:00
fflush ( out ) ;
2001-05-30 15:36:31 +00:00
g_free ( str ) ;
}
2002-12-08 19:17:17 +00:00
# endif /* WITH_VERBOSE_MODE */
2001-05-30 15:36:31 +00:00
2002-12-08 19:17:17 +00:00
# ifdef WITH_VERBOSE_MODE
2001-05-30 15:36:31 +00:00
void
2002-12-08 19:17:17 +00:00
meta_verbose_real ( const char * format , . . . )
2001-05-30 15:36:31 +00:00
{
va_list args ;
gchar * str ;
2001-06-11 05:47:51 +00:00
FILE * out ;
2001-05-30 15:36:31 +00:00
g_return_if_fail ( format ! = NULL ) ;
if ( ! is_verbose )
return ;
va_start ( args , format ) ;
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
2001-06-11 05:47:51 +00:00
out = logfile ? logfile : stderr ;
2001-06-10 19:23:28 +00:00
if ( no_prefix = = 0 )
2002-08-24 20:54:23 +00:00
utf8_fputs ( " Window manager: " , out ) ;
utf8_fputs ( str , out ) ;
2001-06-21 06:08:35 +00:00
fflush ( out ) ;
2001-05-30 15:36:31 +00:00
g_free ( str ) ;
}
2002-12-08 19:17:17 +00:00
# endif /* WITH_VERBOSE_MODE */
2001-05-30 15:36:31 +00:00
2002-12-08 19:17:17 +00:00
# ifdef WITH_VERBOSE_MODE
2002-01-03 23:28:19 +00:00
static const char *
topic_name ( MetaDebugTopic topic )
{
switch ( topic )
{
case META_DEBUG_FOCUS :
return " FOCUS " ;
2002-02-08 03:34:26 +00:00
case META_DEBUG_WORKAREA :
return " WORKAREA " ;
case META_DEBUG_STACK :
return " STACK " ;
case META_DEBUG_THEMES :
return " THEMES " ;
case META_DEBUG_SM :
return " SM " ;
case META_DEBUG_EVENTS :
return " EVENTS " ;
case META_DEBUG_WINDOW_STATE :
return " WINDOW_STATE " ;
case META_DEBUG_WINDOW_OPS :
return " WINDOW_OPS " ;
case META_DEBUG_PLACEMENT :
return " PLACEMENT " ;
case META_DEBUG_GEOMETRY :
return " GEOMETRY " ;
2002-03-02 15:26:07 +00:00
case META_DEBUG_PING :
return " PING " ;
2002-04-21 19:35:02 +00:00
case META_DEBUG_XINERAMA :
return " XINERAMA " ;
2002-04-28 04:52:26 +00:00
case META_DEBUG_KEYBINDINGS :
return " KEYBINDINGS " ;
2002-10-21 21:44:35 +00:00
case META_DEBUG_SYNC :
return " SYNC " ;
case META_DEBUG_ERRORS :
return " ERRORS " ;
2002-10-25 23:35:50 +00:00
case META_DEBUG_STARTUP :
return " STARTUP " ;
2002-11-03 19:06:39 +00:00
case META_DEBUG_PREFS :
return " PREFS " ;
2002-12-01 03:58:04 +00:00
case META_DEBUG_GROUPS :
return " GROUPS " ;
2002-12-10 03:23:04 +00:00
case META_DEBUG_RESIZING :
return " RESIZING " ;
2003-01-05 07:51:02 +00:00
case META_DEBUG_SHAPES :
return " SHAPES " ;
2003-12-26 00:05:26 +00:00
case META_DEBUG_COMPOSITOR :
return " COMPOSITOR " ;
2006-03-17 02:55:21 +00:00
case META_DEBUG_EDGE_RESISTANCE :
return " EDGE_RESISTANCE " ;
2002-01-03 23:28:19 +00:00
}
2003-01-05 18:36:01 +00:00
return " WM " ;
2002-01-03 23:28:19 +00:00
}
2002-11-04 00:56:12 +00:00
static int sync_count = 0 ;
2002-01-03 23:28:19 +00:00
void
2002-12-08 19:17:17 +00:00
meta_topic_real ( MetaDebugTopic topic ,
const char * format ,
. . . )
2002-01-03 23:28:19 +00:00
{
va_list args ;
gchar * str ;
FILE * out ;
g_return_if_fail ( format ! = NULL ) ;
if ( ! is_verbose )
return ;
2002-11-04 00:56:12 +00:00
va_start ( args , format ) ;
2002-01-03 23:28:19 +00:00
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
out = logfile ? logfile : stderr ;
if ( no_prefix = = 0 )
fprintf ( out , " %s: " , topic_name ( topic ) ) ;
2002-11-04 00:56:12 +00:00
if ( topic = = META_DEBUG_SYNC )
{
+ + sync_count ;
fprintf ( out , " %d: " , sync_count ) ;
}
2002-08-24 20:54:23 +00:00
utf8_fputs ( str , out ) ;
2002-01-03 23:28:19 +00:00
fflush ( out ) ;
g_free ( str ) ;
}
2002-12-08 19:17:17 +00:00
# endif /* WITH_VERBOSE_MODE */
2002-01-03 23:28:19 +00:00
2001-05-31 03:30:58 +00:00
void
meta_bug ( const char * format , . . . )
{
va_list args ;
gchar * str ;
2001-06-11 05:47:51 +00:00
FILE * out ;
2001-05-31 03:30:58 +00:00
g_return_if_fail ( format ! = NULL ) ;
va_start ( args , format ) ;
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
2008-02-15 04:37:39 +00:00
# ifdef WITH_VERBOSE_MODE
2001-06-11 05:47:51 +00:00
out = logfile ? logfile : stderr ;
2008-02-15 04:37:39 +00:00
# else
out = stderr ;
# endif
2001-06-10 19:23:28 +00:00
if ( no_prefix = = 0 )
2002-08-24 20:54:23 +00:00
utf8_fputs ( _ ( " Bug in window manager: " ) , out ) ;
utf8_fputs ( str , out ) ;
2001-06-21 06:08:35 +00:00
fflush ( out ) ;
2001-05-31 03:30:58 +00:00
g_free ( str ) ;
2002-10-27 03:03:32 +00:00
meta_print_backtrace ( ) ;
2002-07-23 19:12:02 +00:00
2001-05-31 03:30:58 +00:00
/* stop us in a debugger */
abort ( ) ;
}
2001-05-30 15:36:31 +00:00
void
meta_warning ( const char * format , . . . )
{
va_list args ;
gchar * str ;
2001-06-11 05:47:51 +00:00
FILE * out ;
2001-05-30 15:36:31 +00:00
g_return_if_fail ( format ! = NULL ) ;
va_start ( args , format ) ;
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
2008-02-15 04:37:39 +00:00
# ifdef WITH_VERBOSE_MODE
2001-06-11 05:47:51 +00:00
out = logfile ? logfile : stderr ;
2008-02-15 04:37:39 +00:00
# else
out = stderr ;
# endif
2001-06-10 19:23:28 +00:00
if ( no_prefix = = 0 )
2002-08-24 20:54:23 +00:00
utf8_fputs ( _ ( " Window manager warning: " ) , out ) ;
utf8_fputs ( str , out ) ;
2002-10-21 21:44:35 +00:00
fflush ( out ) ;
2001-05-30 15:36:31 +00:00
g_free ( str ) ;
}
void
meta_fatal ( const char * format , . . . )
{
va_list args ;
gchar * str ;
2001-06-11 05:47:51 +00:00
FILE * out ;
2001-05-30 15:36:31 +00:00
g_return_if_fail ( format ! = NULL ) ;
va_start ( args , format ) ;
str = g_strdup_vprintf ( format , args ) ;
va_end ( args ) ;
2008-02-15 04:37:39 +00:00
# ifdef WITH_VERBOSE_MODE
2001-06-11 05:47:51 +00:00
out = logfile ? logfile : stderr ;
2008-02-15 04:37:39 +00:00
# else
out = stderr ;
# endif
2001-06-10 19:23:28 +00:00
if ( no_prefix = = 0 )
2002-08-24 20:54:23 +00:00
utf8_fputs ( _ ( " Window manager error: " ) , out ) ;
utf8_fputs ( str , out ) ;
2001-06-21 06:08:35 +00:00
fflush ( out ) ;
2001-05-30 15:36:31 +00:00
g_free ( str ) ;
meta_exit ( META_EXIT_ERROR ) ;
}
2001-06-10 19:23:28 +00:00
void
meta_push_no_msg_prefix ( void )
{
+ + no_prefix ;
}
void
meta_pop_no_msg_prefix ( void )
{
g_return_if_fail ( no_prefix > 0 ) ;
- - no_prefix ;
}
2002-01-28 02:09:12 +00:00
void
meta_exit ( MetaExitCode code )
{
exit ( code ) ;
}
2002-08-12 21:32:13 +00:00
gint
meta_unsigned_long_equal ( gconstpointer v1 ,
gconstpointer v2 )
{
return * ( ( const gulong * ) v1 ) = = * ( ( const gulong * ) v2 ) ;
}
guint
meta_unsigned_long_hash ( gconstpointer v )
{
gulong val = * ( const gulong * ) v ;
/* I'm not sure this works so well. */
A load of fixes of issues reported by sparse. Closes bug #152849
2004-09-17 Kjartan Maraas <kmaraas@gnome.org>
* src/bell.c: (meta_bell_flash_screen):
* src/compositor.c:
* src/effects.c: (meta_effects_draw_box_animation):
* src/fixedtip.c: (meta_fixed_tip_show):
* src/frame.c: (find_argb_visual):
* src/frames.c: (unsigned_long_hash), (meta_frames_manage_window),
(meta_frames_apply_shapes):
* src/iconcache.c: (find_largest_sizes), (find_best_size):
* src/keybindings.c: (meta_spawn_command_line_async_on_screen):
* src/main.c: (main):
* src/menu.c: (meta_window_menu_new):
* src/prefs.c: (meta_prefs_get_visual_bell),
(meta_prefs_bell_is_audible), (meta_prefs_get_visual_bell_type),
(meta_prefs_get_action_double_click_titlebar),
(meta_prefs_get_auto_raise), (meta_prefs_get_auto_raise_delay),
(meta_prefs_get_reduced_resources):
* src/screen.c: (meta_create_offscreen_window):
* src/tabpopup.c: (meta_ui_tab_popup_get_selected):
* src/theme-parser.c: (meta_theme_load):
* src/theme.c: (meta_gtk_widget_get_font_desc):
* src/tools/metacity-mag.c: (mouse_press), (begin_area_grab):
* src/util.c: (meta_unsigned_long_hash): A load of fixes of issues
reported by sparse. Closes bug #152849
2004-09-16 23:18:22 +00:00
# if GLIB_SIZEOF_LONG > 4
2002-08-12 21:32:13 +00:00
return ( guint ) ( val ^ ( val > > 32 ) ) ;
# else
return val ;
# endif
}
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
const char *
meta_gravity_to_string ( int gravity )
{
switch ( gravity )
{
case NorthWestGravity :
return " NorthWestGravity " ;
break ;
case NorthGravity :
return " NorthGravity " ;
break ;
case NorthEastGravity :
return " NorthEastGravity " ;
break ;
case WestGravity :
return " WestGravity " ;
break ;
case CenterGravity :
return " CenterGravity " ;
break ;
case EastGravity :
return " EastGravity " ;
break ;
case SouthWestGravity :
return " SouthWestGravity " ;
break ;
case SouthGravity :
return " SouthGravity " ;
break ;
case SouthEastGravity :
return " SouthEastGravity " ;
break ;
case StaticGravity :
return " StaticGravity " ;
break ;
default :
return " NorthWestGravity " ;
break ;
}
}
2008-11-08 18:51:56 +00:00
void
meta_show_dialog ( const char * type ,
const char * message ,
const char * timeout ,
const gint screen_number ,
const char * * columns ,
const char * * entries )
{
GError * error = NULL ;
char * screen_number_text = g_strdup_printf ( " %d " , screen_number ) ;
/*
We want :
zenity - - display X - - screen S - - title Metacity - - error - - text " There was an error running <tt>terminal</tt>: \n \n Your computer is on fire. "
* * with no pipes
zenity - - display X - - screen S - - title Metacity - - question - - text " <big><b><tt>%s</tt> is not responding.</b></big> \n \n <i>You may choose to wait a short while for it to continue or force the application to quit entirely.</i> "
zenity - - display X - - screen S - - title Metacity - - list - - timeout 240 - - text " These windows do not support \" save current setup \" and will have to be restarted manually next time you log in. " - - column " Window " - - column " Class " " Firefox " " foo " " Duke Nukem Forever " " bar "
*/
const char * * argvl ;
int i = 0 ;
GPid child_pid ;
argvl = g_malloc ( sizeof ( char * ) *
( 9 + ( timeout ? 2 : 0 ) )
) ;
argvl [ i + + ] = " zenity " ;
argvl [ i + + ] = type ;
argvl [ i + + ] = " --screen " ;
argvl [ i + + ] = screen_number_text ;
argvl [ i + + ] = " --title " ;
/* Translators: This is the title used on dialog boxes */
argvl [ i + + ] = _ ( " Metacity " ) ;
argvl [ i + + ] = " --text " ;
argvl [ i + + ] = message ;
if ( timeout )
{
argvl [ i + + ] = " --timeout " ;
argvl [ i + + ] = timeout ;
}
argvl [ i ] = NULL ;
g_spawn_async_with_pipes (
" / " ,
( char * * ) argvl , /* ugh */
NULL ,
G_SPAWN_SEARCH_PATH ,
NULL , NULL ,
& child_pid ,
NULL , NULL , NULL ,
& error
) ;
g_free ( argvl ) ;
g_free ( screen_number_text ) ;
if ( error )
{
meta_warning ( " %s \n " , error - > message ) ;
g_error_free ( error ) ;
}
}
/* eof util.c */