isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
gnome-shell/js/ui
History
Sergio Costas d75a3484d6 windowManager: detect change to a non-existent WS 
When using dynamic workspaces, it is possible to try to change to a
non-existent one if the user defines hotkeys for changing to desktop
1, 2, 3... This case is not detected, and gnome shell shows an error:

JS ERROR: TypeError: workspace is null
actionMoveWorkspace@resource:///org/gnome/shell/ui/windowManager.js:2130:13
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
_showWorkspaceSwitcher@resource:///org/gnome/shell/ui/windowManager.js:2104:13
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22

This patch adds a check before trying to change the workspace, to avoid
switching to a non-existent one.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/365
2019-01-24 23:59:23 +01:00
..
components
polkitAgent: Disconnect from user signals when closing dialogue
2019-01-24 14:48:48 +00:00
status
keyboard: Disconnect from input source manager when destroying indicator
2019-01-24 14:48:48 +00:00
accessDialog.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
altTab.js
windowIcon: Subclass St.BoxLayout
2018-10-08 22:42:24 -03:00
animation.js
animation: Disable spinner animations when actor is destroyed
2019-01-24 00:20:58 +01:00
appDisplay.js
app-usage: Remove crufty old "context"s idea
2018-11-17 12:08:33 +00:00
appFavorites.js
Add Iagno to appFavorites
2019-01-15 15:31:13 +00:00
audioDeviceSelection.js
audioDeviceSelection: Only include settings button when allowed
2019-01-16 00:30:46 +00:00
background.js
Remove usage of MetaScreen
2018-07-06 19:56:19 +02:00
backgroundMenu.js
cleanup: Use arrow notation for anonymous functions
2018-02-21 13:55:00 +00:00
barLevel.js
barLevel: Add "overdrive" capability
2018-07-31 18:14:14 +00:00
boxpointer.js
boxPointer: Stop using Shell.GenericContainer
2018-10-08 22:43:01 -03:00
calendar.js
calendar: Rename "Clear All" button
2019-01-22 21:35:52 +00:00
checkBox.js
cleanup: Use method syntax
2018-02-21 13:54:58 +00:00
closeDialog.js
closeDialog: Untrack chrome when window loses focus
2018-10-08 16:03:53 +00:00
ctrlAltTab.js
switcherList: Stop using Shell.GenericContainer
2018-10-08 22:42:24 -03:00
dash.js
dash: destroy items's child before tooltip
2018-11-19 15:51:32 +00:00
dateMenu.js
Remove padding from date strings
2018-10-25 13:05:47 +02:00
dialog.js
js/ui: Choose some actors to cache on the GPU
2018-08-27 14:16:59 +00:00
dnd.js
dnd: Repick target actor if destroyed mid iteration
2019-01-09 16:15:59 +00:00
edgeDragAction.js
Remove usage of MetaScreen
2018-07-06 19:56:19 +02:00
endSessionDialog.js
endSessionDialog: squash "reference to undefined property" warning
2018-09-25 21:28:35 +01:00
environment.js
cleanup: Remove obsolete Lang imports
2019-01-22 21:33:46 +00:00
extensionDownloader.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
extensionSystem.js
cleanup: Remove obsolete Lang imports
2019-01-22 21:33:46 +00:00
focusCaretTracker.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
grabHelper.js
cleanup: Use arrow notation for anonymous functions
2018-02-21 13:55:00 +00:00
ibusCandidatePopup.js
boxPointer: Stop using Shell.GenericContainer
2018-10-08 22:43:01 -03:00
iconGrid.js
iconGrid: Eliminate JavaScript for painting/picking
2018-11-27 13:25:37 +00:00
inhibitShortcutsDialog.js
cleanup: Use method syntax
2018-02-21 13:54:58 +00:00
kbdA11yDialog.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
keyboard.js
keyboard: Use addSettingsItem() in language menu
2019-01-16 00:29:23 +00:00
layout.js
layout: Always allow hiding the overview
2019-01-09 15:47:38 +00:00
lightbox.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
lookingGlass.js
lookingGlass: Stop using eval()
2019-01-22 21:33:46 +00:00
magnifier.js
Remove usage of MetaScreen
2018-07-06 19:56:19 +02:00
magnifierDBus.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
main.js
Add app introspection API
2019-01-09 10:13:45 +01:00
messageList.js
calendar: Don't allow event messages to be closed
2019-01-22 21:35:52 +00:00
messageTray.js
messageTray: Chain up in NotificationPolicy constructor
2019-01-22 21:33:46 +00:00
modalDialog.js
Remove usage of MetaScreen
2018-07-06 19:56:19 +02:00
mpris.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
notificationDaemon.js
notificationDaemon.js: Fix a typo (missing ')')
2019-01-17 11:55:04 +08:00
osdMonitorLabeler.js
Remove usage of MetaScreen
2018-07-06 19:56:19 +02:00
osdWindow.js
osdWindow: Disconnect signals on destroy
2018-10-22 14:58:50 +00:00
overview.js
panel: Stop using Shell.GenericContainer
2018-10-08 22:42:23 -03:00
overviewControls.js
thumbnailBox: Stop using Shell.GenericContainer
2018-10-08 22:42:25 -03:00
padOsd.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
panel.js
panel: Also ignore hidden windows for proximity
2018-10-23 16:24:22 +02:00
panelMenu.js
panel: Delegate container destruction to PanelMenu.ButtonBox
2018-10-08 22:43:13 -03:00
pointerWatcher.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
popupMenu.js
popupMenu: Handle keypress if numlock is enabled
2018-10-11 07:45:44 +00:00
remoteMenu.js
remoteMenu: Support icons in app-menu
2018-04-14 09:02:20 +00:00
remoteSearch.js
js: use ES6 template strings for dbus interfaces
2018-08-27 19:23:00 +02:00
runDialog.js
runDialog: Use ClutterText::activate for enter handling
2018-08-17 18:37:32 +00:00
screencast.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
screenShield.js
messageTray: Drop Shell.GenericContainer usage
2018-10-08 22:42:26 -03:00
screenshot.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
scripting.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
search.js
search: Initialise searchInProgress when search providers are registered
2019-01-24 14:48:48 +00:00
sessionMode.js
Explicitly convert raw data to strings
2018-07-31 16:28:53 +00:00
shellDBus.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
shellEntry.js
shellEntry: Use correct enum for input purpose hints
2018-03-14 13:30:47 +00:00
shellMountOperation.js
dbus: Move all interface descriptions into the resource
2018-09-17 07:34:49 +00:00
slider.js
barLevel: Support maxValue higher than 1
2018-07-31 18:14:10 +00:00
switcherPopup.js
switcherPopup: Bind to the stage, not the monitor
2018-10-25 12:33:10 -03:00
switchMonitor.js
switchMonitor: switch to next config upon initial keypress
2018-09-13 16:11:16 +00:00
tweener.js
cleanup: Use arrow notation for anonymous functions
2018-02-21 13:55:00 +00:00
unlockDialog.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
userWidget.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00
viewSelector.js
viewSelector: Don't unfocus other modals on reset
2018-10-04 16:40:46 +00:00
windowAttentionHandler.js
windowAttentionHandler: Fix syntax errors
2018-11-14 19:38:33 +01:00
windowManager.js
windowManager: detect change to a non-existent WS
2019-01-24 23:59:23 +01:00
windowMenu.js
windowMenu: Port from Meta.ScreenDirection to Meta.DisplayDirection
2018-09-11 12:59:07 +02:00
workspace.js
theme: Drop custom assets for window close buttons in overview
2018-11-22 23:50:24 +01:00
workspacesView.js
workspaces: Use correct schema for workspace settings
2018-11-08 10:50:32 +01:00
workspaceSwitcherPopup.js
workspaceSwitcherPopup: Stop using Shell.GenericContainer
2018-10-08 22:42:26 -03:00
workspaceThumbnail.js
workspaces: Use correct schema for workspace settings
2018-11-08 10:50:32 +01:00
xdndHandler.js
cleanup: Use Function.prototype.bind()
2018-02-21 13:55:02 +00:00