isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
15,056 Commits 179 Branches 237 Tags 67 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
d04daf6a1c
Go to file
Georges Basile Stavracas Neto d04daf6a1c appDisplay: Protect against source icon destruction 
When dragging icons out of a folder dialog, there is a very peculiar
combination of steps that may break GNOME Shell:

 1. Open an app folder dialog
 2. Start dragging an icon to outside the grid
 3. Wait until the popdown animation starts
 4. Before it finishes, drop the icon
 5. See the warnings / crash

That's caused by the source icon being destroyed after the delayed
move timer starts, and before it finishes.

Protect against the source icon being destroyed before the delayed
move timeout triggers by connecting to the 'destroy' signal and
removing the timeout on the callback. Use a single field, called
'_delayedMoveData', to store all data related to delayed moves.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1447
2020-10-05 12:06:48 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-07 22:42:46 +00:00
.gitlab-ci ci: Rebase extension-ci image to F32 2020-04-28 09:04:49 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data CSS: Add border around avatars 2020-09-22 13:51:13 +00:00
docs/reference docs: Remove obsolete ShellRecorder include 2020-09-25 18:37:22 +02:00
js appDisplay: Protect against source icon destruction 2020-10-05 12:06:48 +00:00
lint JS: migrate from the global window to globalThis 2020-04-26 19:07:02 -07:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson extensionPrefs: Add application icon 2020-02-03 19:03:19 +01:00
po Update Hebrew translation 2020-09-28 17:20:09 +00:00
src shell: Do not use stack-allocated ClutterEvents 2020-09-30 22:47:11 +02:00
subprojects subprojects: Update libgvc 2020-09-21 15:08:46 +02:00
tests Remove ClutterAllocationFlags 2020-05-20 15:12:03 +02:00
tools *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-28 00:06:19 +02:00
.gitlab-ci.yml ci: Remove pot file test 2020-08-07 21:52:00 +02:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Add Georges Stavracas as a maintainer 2019-12-18 15:24:38 -03:00
HACKING.md *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
meson_options.txt extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
meson.build Bump version to 3.38.0 2020-09-14 17:56:13 +02:00
NEWS Bump version to 3.38.0 2020-09-14 17:56:13 +02:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.