isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
bde1451896
gnome-shell/js/ui/status
History
Giovanni Campagna bde1451896 NMDeviceWired: don't unconditionally access device.active_connection 
The active_connection might be null, but the NMApplet code might
still belive the device wrapper is the primary connection (because
dbus signals are emitted one after the other).
(Also, remove an old and wrong comment about bluetooth in wwan code)

Fixes:

(gnome-shell:22511): Gjs-WARNING **: JS ERROR: Exception in callback for signal: icon-changed: TypeError: this._device.active_connection is null
NMDeviceWired<.getIndicatorIcon@resource:///org/gnome/shell/ui/status/network.js:475
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
NMApplet<._updateIcon@resource:///org/gnome/shell/ui/status/network.js:1790
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_emit@resource:///org/gnome/gjs/modules/signals.js:124
NMConnectionSection<._addConnection/<@resource:///org/gnome/shell/ui/status/network.js:265
_emit@resource:///org/gnome/gjs/modules/signals.js:124
NMConnectionItem<._sync@resource:///org/gnome/shell/ui/status/network.js:137
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
NMConnectionItem<.setActiveConnection@resource:///org/gnome/shell/ui/status/network.js:169
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
NMConnectionDevice<._activeConnectionChanged@resource:///org/gnome/shell/ui/status/network.js:327
wrapper@resource:///org/gnome/gjs/modules/lang.js:169

https://bugzilla.gnome.org/show_bug.cgi?id=723570
2014-02-17 20:44:57 +01:00
..
accessibility.js js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions 2013-12-16 18:27:19 +01:00
bluetooth.js BluetoothMenu: show the submenu when active but not connected 2014-02-06 19:07:48 +01:00
brightness.js js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers 2013-12-16 18:27:19 +01:00
keyboard.js Stringify the xml definitions for E4X removal 2013-10-25 08:57:27 +11:00
location.js Revert "location: Allow user to disable GPS" 2014-02-17 15:49:34 +00:00
network.js NMDeviceWired: don't unconditionally access device.active_connection 2014-02-17 20:44:57 +01:00
power.js Stringify the xml definitions for E4X removal 2013-10-25 08:57:27 +11:00
rfkill.js rfkill: split out the dbus handling parts from the indicator 2014-02-04 22:24:00 +01:00
screencast.js Add a screencast indicator for when we're recording 2013-08-14 20:39:07 -04:00
system.js js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers 2013-12-16 18:27:19 +01:00
volume.js js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers 2013-12-16 18:27:19 +01:00