isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
12,751 Commits 179 Branches 237 Tags 66 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
96c2473317
Go to file
Cosimo Cecchi 96c2473317 modemManager: improve check for CDMA system identifier 
Upon construction of the CDMA modem proxy, _reloadCdmaOperatorName()
is called and the value of the Sid property is read.
That property is defined as UINT32 in the D-Bus interface, but the
value may not be loaded yet after the proxy is constructed, in which
case its value will be null.

In _findProviderForSid(), we'll end up calling lookup_cdma_sid(null)
which fails with the following assertion:

gnome-shell[1082]: nma_mobile_providers_database_lookup_cdma_sid: assertion 'sid > 0' failed

This commit changes the (sid == 0) check in _findProviderForSid()
to (!sid) which will also catch the null case.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/555
2019-05-27 08:36:05 -07:00
.gitlab-ci ci: Switch to mutter's docker image 2019-05-17 20:52:44 +02:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data shellMountOperation: Support TCRYPT 2019-05-20 19:59:04 +02:00
docs/reference shell: Remove ShellGenericContainer 2018-10-08 22:44:14 -03:00
js modemManager: improve check for CDMA system identifier 2019-05-27 08:36:05 -07:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson build: Run postinstall script where necessary 2018-04-09 19:19:33 +00:00
po Updated Spanish translation 2019-05-16 12:41:26 +02:00
src shell: Only initialize global->xdisplay on X11 compositors 2019-05-24 12:24:06 +02:00
subprojects gvc: Update submodule to up-to-date version 2019-02-28 21:59:08 +01:00
test Add convert_xml test 2019-03-04 20:55:15 +00:00
tests cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.gitignore Ignore '.vscode' folder for users of that editor 2019-04-02 17:37:31 +00:00
.gitlab-ci.yml calendar-server: Port to libecal-2.0 2019-05-17 20:24:08 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
cldr2json.py Fix override for fr-CA 2019-03-04 20:55:15 +00:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap Replace Bugzilla by Gitlab URL in DOAP file 2018-12-15 23:26:54 +01:00
HACKING.md cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
meson_options.txt Remove the browser plugin 2018-12-31 13:25:05 -06:00
meson.build Bump version to 3.33.2 2019-05-22 18:23:02 +00:00
NEWS Bump version to 3.33.2 2019-05-22 18:23:02 +00:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00
README.mdwn Add basic documentation 2019-03-04 20:55:15 +00:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.