606ec25f8b
If the icon surface of a window got updated and its type or format no longer match what we expect, st_texture_cache_reset_texture() might overwrite the existing image in the bind with a new image, while still keeping the weak ref on the old image. Due to this the old image might trigger a st_texture_cache_on_pixbuf_notify() after the bind has already been freed by g_signal_handlers_destroy() in the bind source. While this usually would remove the weak ref, the weak ref it tries to remove is on the new image, not the old one. The call to st_texture_cache_on_pixbuf_notify() then tries to read the already free'd memory from the bind which causes the cast to G_OBJECT to fail, resulting in the crash. Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3785 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1718>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.