isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5fb8d4f730
gnome-shell/js/ui
History
Cosimo Cecchi 5fb8d4f730 calendar: do not call destroy() recursively 
We have a callback that will call close() when the notification is
destroyed, and a callback that will call destroy() on the notification
when the message is closed.

Currently, if the notification is destroyed we'll execute our callback
that will call again destroy() on the notification. That's bad
practice in general, and it also has the side effect of resetting the
destroy reason.

This commit avoids re-destroying the notification by dropping the
notification reference on destroy.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/258
2018-11-10 10:56:49 +00:00
..
components automountManager: Add handling of udisks errors for no/wrong passwords 2018-10-24 00:13:10 +02:00
status keyboard: Do not call KeyboardManager.holdKeyboard() with set-content-type 2018-11-09 10:55:30 +00:00
accessDialog.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
altTab.js windowIcon: Subclass St.BoxLayout 2018-10-08 22:42:24 -03:00
animation.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
appDisplay.js appFolder: Don't block all shortcuts 2018-10-11 20:12:54 +02:00
appFavorites.js appFavorites: Don't add app explicitly 2018-10-08 16:22:04 +00:00
audioDeviceSelection.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
background.js Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
backgroundMenu.js cleanup: Use arrow notation for anonymous functions 2018-02-21 13:55:00 +00:00
barLevel.js barLevel: Add "overdrive" capability 2018-07-31 18:14:14 +00:00
boxpointer.js boxPointer: Stop using Shell.GenericContainer 2018-10-08 22:43:01 -03:00
calendar.js calendar: do not call destroy() recursively 2018-11-10 10:56:49 +00:00
checkBox.js cleanup: Use method syntax 2018-02-21 13:54:58 +00:00
closeDialog.js closeDialog: Untrack chrome when window loses focus 2018-10-08 16:03:53 +00:00
ctrlAltTab.js switcherList: Stop using Shell.GenericContainer 2018-10-08 22:42:24 -03:00
dash.js dash: expand and center align DashItemContainer 2018-10-08 22:43:13 -03:00
dateMenu.js Remove padding from date strings 2018-10-25 13:05:47 +02:00
dialog.js js/ui: Choose some actors to cache on the GPU 2018-08-27 14:16:59 +00:00
dnd.js dnd: Nullify _dragActor after we've destroyed it, and avoid invalid access 2018-09-03 22:43:21 +00:00
edgeDragAction.js Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
endSessionDialog.js endSessionDialog: squash "reference to undefined property" warning 2018-09-25 21:28:35 +01:00
environment.js cleanup: Use arrow notation for anonymous functions 2018-02-21 13:55:00 +00:00
extensionDownloader.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
extensionSystem.js extensionSystem: Unset stylesheet file reference when unloaded 2018-09-03 23:29:01 +00:00
focusCaretTracker.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
grabHelper.js cleanup: Use arrow notation for anonymous functions 2018-02-21 13:55:00 +00:00
ibusCandidatePopup.js boxPointer: Stop using Shell.GenericContainer 2018-10-08 22:43:01 -03:00
iconGrid.js iconGrid: Keep icons reactive during pulse animation 2018-10-30 19:58:52 +01:00
inhibitShortcutsDialog.js cleanup: Use method syntax 2018-02-21 13:54:58 +00:00
kbdA11yDialog.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
keyboard.js boxPointer: Stop using Shell.GenericContainer 2018-10-08 22:43:01 -03:00
layout.js layoutManager: Subclass GObject.Object 2018-10-08 22:42:26 -03:00
lightbox.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
lookingGlass.js inspector: Stop using Shell.GenericContainer 2018-10-08 22:43:01 -03:00
magnifier.js Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
magnifierDBus.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
main.js js/main: Throw error if no valid default stylesheet is found 2018-09-03 23:29:01 +00:00
messageList.js messageList: stop syncing if closeButton has been destroyed 2018-09-03 22:43:21 +00:00
messageTray.js notificationDaemon: use different reason when replacing notification 2018-11-10 10:56:49 +00:00
modalDialog.js Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
mpris.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
notificationDaemon.js notificationDaemon: use different reason when replacing notification 2018-11-10 10:56:49 +00:00
osdMonitorLabeler.js Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
osdWindow.js osdWindow: Disconnect signals on destroy 2018-10-22 14:58:50 +00:00
overview.js panel: Stop using Shell.GenericContainer 2018-10-08 22:42:23 -03:00
overviewControls.js thumbnailBox: Stop using Shell.GenericContainer 2018-10-08 22:42:25 -03:00
padOsd.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
panel.js panel: Also ignore hidden windows for proximity 2018-10-23 16:24:22 +02:00
panelMenu.js panel: Delegate container destruction to PanelMenu.ButtonBox 2018-10-08 22:43:13 -03:00
pointerWatcher.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
popupMenu.js popupMenu: Handle keypress if numlock is enabled 2018-10-11 07:45:44 +00:00
remoteMenu.js remoteMenu: Support icons in app-menu 2018-04-14 09:02:20 +00:00
remoteSearch.js js: use ES6 template strings for dbus interfaces 2018-08-27 19:23:00 +02:00
runDialog.js runDialog: Use ClutterText::activate for enter handling 2018-08-17 18:37:32 +00:00
screencast.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
screenShield.js messageTray: Drop Shell.GenericContainer usage 2018-10-08 22:42:26 -03:00
screenshot.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
scripting.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
search.js iconGrid: Stop using Shell.GenericContainer 2018-10-08 22:42:25 -03:00
sessionMode.js Explicitly convert raw data to strings 2018-07-31 16:28:53 +00:00
shellDBus.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
shellEntry.js shellEntry: Use correct enum for input purpose hints 2018-03-14 13:30:47 +00:00
shellMountOperation.js dbus: Move all interface descriptions into the resource 2018-09-17 07:34:49 +00:00
slider.js barLevel: Support maxValue higher than 1 2018-07-31 18:14:10 +00:00
switcherPopup.js switcherPopup: Bind to the stage, not the monitor 2018-10-25 12:33:10 -03:00
switchMonitor.js switchMonitor: switch to next config upon initial keypress 2018-09-13 16:11:16 +00:00
tweener.js cleanup: Use arrow notation for anonymous functions 2018-02-21 13:55:00 +00:00
unlockDialog.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
userWidget.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
viewSelector.js viewSelector: Don't unfocus other modals on reset 2018-10-04 16:40:46 +00:00
windowAttentionHandler.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00
windowManager.js panel: Stop using Shell.GenericContainer 2018-10-08 22:42:23 -03:00
windowMenu.js windowMenu: Port from Meta.ScreenDirection to Meta.DisplayDirection 2018-09-11 12:59:07 +02:00
workspace.js workspace: Simplify detecting added dialogs after closing a window 2018-08-03 00:09:02 +02:00
workspacesView.js workspaces: Use correct schema for workspace settings 2018-11-08 10:50:32 +01:00
workspaceSwitcherPopup.js workspaceSwitcherPopup: Stop using Shell.GenericContainer 2018-10-08 22:42:26 -03:00
workspaceThumbnail.js workspaces: Use correct schema for workspace settings 2018-11-08 10:50:32 +01:00
xdndHandler.js cleanup: Use Function.prototype.bind() 2018-02-21 13:55:02 +00:00