isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
59edea4bb4
gnome-shell/js/ui
History
Carlos Garnacho 59edea4bb4 workspacesView: sync gesture enabled state after setting it up completely 
At the point it is disabled, it has got signal handlers connected but
this._workspacesView is uninitialized. This triggers:

(gnome-shell:3993): Gjs-WARNING **: 18:49:53.281: JS ERROR: Exception in callback for signal: cancel: TypeError: this._workspacesViews is undefined
_endTouchGesture@resource:///org/gnome/shell/ui/workspacesView.js:527:25
_emit@resource:///org/gnome/gjs/modules/signals.js:142:27
set enabled@resource:///org/gnome/shell/ui/windowManager.js:478:13
WorkspacesDisplay<@resource:///org/gnome/shell/ui/workspacesView.js:482:9
ViewSelector<@resource:///org/gnome/shell/ui/viewSelector.js:167:35
ControlsManager<@resource:///org/gnome/shell/ui/overviewControls.js:405:29
init@resource:///org/gnome/shell/ui/overview.js:234:26
_initializeUI@resource:///org/gnome/shell/ui/main.js:184:5
start@resource:///org/gnome/shell/ui/main.js:124:5
@<main>:1:31

On startup. Shuffling these two lines prevent this from happening.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/506
2019-04-19 18:58:33 +02:00
..
components automountManager: Fix playing disconnected sound 2019-03-04 14:39:40 +01:00
status panelMenu: Remove usage of this.actor from Button 2019-04-17 21:32:18 +00:00
accessDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
altTab.js windowCycler: Create settings before chaining up 2019-03-18 09:48:02 +00:00
animation.js animation: Reload sliced texture on global scale change 2019-03-01 17:12:53 +00:00
appDisplay.js popupMenu: Make MenuManager to take an actor as parameter 2019-04-17 21:32:18 +00:00
appFavorites.js appFavorites: Update RENAMED_DESKTOP_IDS 2019-04-11 23:28:49 +02:00
audioDeviceSelection.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
background.js background: Don't set background actor sizing and scaling 2019-03-01 17:12:53 +00:00
backgroundMenu.js popupMenu: Make MenuManager to take an actor as parameter 2019-04-17 21:32:18 +00:00
barLevel.js barLevel: Don't show border radius if the value is 0 2019-04-17 18:38:13 +00:00
boxpointer.js boxpointer: Don't use boxpointer actor, as it's now an actor itself 2019-04-17 21:32:18 +00:00
calendar.js calendar: Load interface description from resource 2019-02-13 17:58:36 +00:00
checkBox.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
closeDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
ctrlAltTab.js st-texture-cache: use StImageContent for cairo bound surface 2019-03-01 17:12:53 +00:00
dash.js dash: Fix messed up icon height 2019-04-13 14:17:07 +00:00
dateMenu.js panelMenu: Remove usage of this.actor from Button 2019-04-17 21:32:18 +00:00
dialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
dnd.js dnd: Multiply drag threshold by output scale 2019-03-13 17:22:35 +00:00
edgeDragAction.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
endSessionDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
environment.js environment: Warn when trying to access a deprecated actor property 2019-04-17 21:32:18 +00:00
extensionDownloader.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
extensionSystem.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
focusCaretTracker.js cleanup: Port non-GObject classes to JS6 classes 2019-01-25 14:02:44 +00:00
grabHelper.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
ibusCandidatePopup.js boxpointer: Don't use boxpointer actor, as it's now an actor itself 2019-04-17 21:32:18 +00:00
iconGrid.js iconGrid: Remove this.actor definition to BaseIcon 2019-04-17 21:32:18 +00:00
inhibitShortcutsDialog.js inhibitShortcuts: Save choice in permission store 2019-03-04 10:12:58 +01:00
kbdA11yDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
keyboard.js boxpointer: Don't use boxpointer actor, as it's now an actor itself 2019-04-17 21:32:18 +00:00
layout.js layout: Use an invisible but mapped actor as dummy cursor 2019-04-11 19:38:17 +00:00
lightbox.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
lookingGlass.js lookingGlass: Use symbolic icon for close button 2019-02-28 16:21:38 +01:00
magnifier.js st/settings: Add magnifier activation property and bind to settings 2019-04-02 20:28:54 +00:00
magnifierDBus.js cleanup: Port non-GObject classes to JS6 classes 2019-01-25 14:02:44 +00:00
main.js main: Wait for startup completion before running perf script 2019-03-21 10:18:02 +00:00
messageList.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
messageTray.js messageTray: Remove this.actor definition to SourceActor 2019-04-17 21:32:18 +00:00
modalDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
mpris.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
notificationDaemon.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
osdMonitorLabeler.js shellDBus: Remove ShowMonitorLabels API 2019-04-11 17:49:40 +00:00
osdWindow.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
overview.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
overviewControls.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
padOsd.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
pageIndicators.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
panel.js panel: Remove this.actor definition to self 2019-04-17 21:32:18 +00:00
panelMenu.js panelMenu: Remove usage of this.actor from Button 2019-04-17 21:32:18 +00:00
pointerWatcher.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
popupMenu.js popupMenu: Make MenuManager to take an actor as parameter 2019-04-17 21:32:18 +00:00
remoteSearch.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
runDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screencast.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screenShield.js screenShield: Handle signal 'StatusChanged' when lockscreen is active 2019-03-18 08:32:54 +08:00
screenshot.js screenshot: Don't pick up rubberband style from GTK 2019-04-11 17:27:50 +00:00
scripting.js scripting: Don't use legacy API 2019-03-21 10:18:02 +00:00
search.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
sessionMode.js cleanup: Clean up unused imports 2019-02-09 05:05:07 +01:00
shellDBus.js shellDBus: Accept connector to restrict OSD to one monitor 2019-04-11 18:53:53 +00:00
shellEntry.js popupMenu: Make MenuManager to take an actor as parameter 2019-04-17 21:32:18 +00:00
shellMountOperation.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
slider.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
switcherPopup.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
switchMonitor.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
tweener.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
unlockDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
userWidget.js userWidget: Fix avatar size 2019-03-12 00:34:04 +00:00
viewSelector.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
windowAttentionHandler.js windowAttentionHandler: Don't destroy on open 2019-03-02 22:09:33 +01:00
windowManager.js windowManager: ensure actor resize clone dies with actor 2019-04-17 18:31:22 +00:00
windowMenu.js popupMenu: Make MenuManager to take an actor as parameter 2019-04-17 21:32:18 +00:00
workspace.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
workspacesView.js workspacesView: sync gesture enabled state after setting it up completely 2019-04-19 18:58:33 +02:00
workspaceSwitcherPopup.js workspaceSwitcherPopup: Remove this.actor definition to self 2019-04-17 21:32:18 +00:00
workspaceThumbnail.js workspaceThumbnail: Remove this.actor definition to ThumbnailsBox 2019-04-17 21:32:18 +00:00
xdndHandler.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00