Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
5610a2435d
The `reactive` property of icon actors was being restored 24 times over
the course of the spring animation, all at slightly different times as
each icon finished animating at different times.
The problem is that toggling `reactive` on an `StWidget` incurs a style
change of the `insensitive` pseudo class, and style changes would quickly
queue relayouts incurring full stage reallocation. This occurred many times
during a spring animation hogging the CPU and limiting the frame rate.
The solution is defer and batch the cleanup for all icons until after the
last icon has finished animating. This way the CPU impact of the style
change and stage relayout isn't felt during the animation so the frame
rate remains higher and smoother. The overall CPU usage of the animation
is also reduced as the remaining relayouts are much more likely to be
grouped into a single frame.
Icon spring animation performance on an i7-7700:
Before: 83% CPU and 47 FPS
After : 78% CPU and 54 FPS
which is about a 22% increase in performance per clock (FPS/CPU).
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/253
(cherry picked from commit
|
||
|---|---|---|
| .settings | ||
| browser-plugin | ||
| data | ||
| docs/reference | ||
| js | ||
| man | ||
| meson | ||
| po | ||
| src | ||
| subprojects | ||
| tests | ||
| tools/build | ||
| .gitignore | ||
| .gitmodules | ||
| .project | ||
| AUTHORS | ||
| config.h.meson | ||
| COPYING | ||
| gnome-shell.doap | ||
| HACKING | ||
| MAINTAINERS | ||
| meson_options.txt | ||
| meson.build | ||
| NEWS | ||
| README | ||
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: https://wiki.gnome.org/Projects/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.