isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
14,505 Commits 179 Branches 237 Tags 67 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
527ce66cd4
Go to file
Matthew Leeds 527ce66cd4 screenShield: Fix use of null this._dialog 
On Fedora 32 if you close the laptop lid during gnome-initial-setup,
gnome-shell hits this error:

JS ERROR: Exception in callback for signal: prepare-for-sleep: TypeError: this._dialog is undefined
_resetLockScreen@resource:///org/gnome/shell/ui/screenShield.js:434:9
activate@resource:///org/gnome/shell/ui/screenShield.js:571:14
lock@resource:///org/gnome/shell/ui/screenShield.js:617:14
_prepareForSleep@resource:///org/gnome/shell/ui/screenShield.js:219:22
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:133:47
_prepareForSleep@resource:///org/gnome/shell/misc/loginManager.js:198:14
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:133:47
_convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:169:19

This is because _ensureUnlockDialog() hit its first early return. So
return early from activate() in that case, so this._dialog doesn't get
used while it's null.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1213
2020-04-24 23:47:31 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-07 22:42:46 +00:00
.gitlab-ci ci: Handle POTFILES.skip in potfiles check 2020-04-07 20:27:00 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data theme: tone down weekend with events 2020-04-06 20:54:37 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js screenShield: Fix use of null this._dialog 2020-04-24 23:47:31 +00:00
lint extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson extensionPrefs: Add application icon 2020-02-03 19:03:19 +01:00
po Update Persian translation 2020-04-24 20:06:24 +00:00
src st: Update to new API for creating paint context 2020-04-23 14:46:03 +00:00
subprojects extension-tool/build: Install completions relative to our datadír 2020-04-13 15:27:09 +00:00
tests Use paint and pick context to get framebuffer 2019-12-03 19:07:15 +00:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore theme: use the fontsize function consistently 2020-01-09 16:43:26 +01:00
.gitlab-ci.yml ci: Revert to a previous version of the flatpak template 2020-04-24 20:34:32 +02:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Add Georges Stavracas as a maintainer 2019-12-18 15:24:38 -03:00
HACKING.md docs: Conform to coding style in HACKING guide 2020-01-06 19:53:21 +01:00
meson_options.txt extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
meson.build build: Obtain systemduserunitdir from pkg-config 2020-04-13 15:27:09 +00:00
NEWS Bump version to 3.36.0 2020-03-07 23:30:33 +01:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.