isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5150166336
gnome-shell/js
History
Carlos Garnacho 5150166336 workspacesView: sync gesture enabled state after setting it up completely 
At the point it is disabled, it has got signal handlers connected but
this._workspacesView is uninitialized. This triggers:

(gnome-shell:3993): Gjs-WARNING **: 18:49:53.281: JS ERROR: Exception in callback for signal: cancel: TypeError: this._workspacesViews is undefined
_endTouchGesture@resource:///org/gnome/shell/ui/workspacesView.js:527:25
_emit@resource:///org/gnome/gjs/modules/signals.js:142:27
set enabled@resource:///org/gnome/shell/ui/windowManager.js:478:13
WorkspacesDisplay<@resource:///org/gnome/shell/ui/workspacesView.js:482:9
ViewSelector<@resource:///org/gnome/shell/ui/viewSelector.js:167:35
ControlsManager<@resource:///org/gnome/shell/ui/overviewControls.js:405:29
init@resource:///org/gnome/shell/ui/overview.js:234:26
_initializeUI@resource:///org/gnome/shell/ui/main.js:184:5
start@resource:///org/gnome/shell/ui/main.js:124:5
@<main>:1:31

On startup. Shuffling these two lines prevent this from happening.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/506


(cherry picked from commit 59edea4bb4)
2019-05-08 21:20:21 +00:00
..
extensionPrefs extensionPrefs: Fix pref button appearance 2019-04-12 00:51:44 +02:00
gdm loginDialog: Load logo file texture given resource scale 2019-03-01 17:12:53 +00:00
misc weather: Handle missing permission store 2019-04-03 13:27:42 +00:00
perf perf: Stop using GTK 2019-04-11 17:27:50 +00:00
portalHelper cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
ui workspacesView: sync gesture enabled state after setting it up completely 2019-05-08 21:20:21 +00:00
js-resources.gresource.xml build: Remove remote menu support 2019-02-06 18:29:15 +01:00
meson.build build: Use dedicated resources for helper programs 2018-08-14 17:28:04 +00:00
portal-resources.gresource.xml build: Include params.js in portal-helper gresources 2018-10-23 15:38:31 +00:00
prefs-resources.gresource.xml build: Use dedicated resources for helper programs 2018-08-14 17:28:04 +00:00