45ebb94b33
When cancelling the PolkitAgent session before disconnecting the signal handlers, we receive a "completed" signal where `gained_authorization` is set to FALSE, which means we show an error message inside `_onSessionCompleted()`. This in turn means we show an error message every time we cancel a session. In practice this wasn't really relevant so far since we only destroyed the session when an actual error occurred before. Now that the dialog supports empty passwords, we also call `_destroySession()` when the user changes and no longer has a password set, and in this case we want to cancel the current session without showing an error message. So to fix this, disconnect the signal handlers before cancelling the session, which makes sure we don't receive the last "completed" signal in case we cancelled the session ourselves. This change also allows removing `this._wasDismissed`. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/829
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.