isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
13,518 Commits 179 Branches 237 Tags 67 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
45ebb94b33
Go to file
Jonas Dreßler 45ebb94b33 polkitAgent: Cancel session after disconnecting signal handlers 
When cancelling the PolkitAgent session before disconnecting the signal
handlers, we receive a "completed" signal where `gained_authorization`
is set to FALSE, which means we show an error message inside
`_onSessionCompleted()`.

This in turn means we show an error message every time we cancel a
session. In practice this wasn't really relevant so far since we only
destroyed the session when an actual error occurred before. Now that the
dialog supports empty passwords, we also call `_destroySession()` when
the user changes and no longer has a password set, and in this case we
want to cancel the current session without showing an error message.

So to fix this, disconnect the signal handlers before cancelling the
session, which makes sure we don't receive the last "completed" signal
in case we cancelled the session ourselves. This change also allows
removing `this._wasDismissed`.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/829
2019-11-16 12:09:25 +01:00
.gitlab-ci lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data style: Don't specify font-family 2019-11-08 23:48:42 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js polkitAgent: Cancel session after disconnecting signal handlers 2019-11-16 12:09:25 +01:00
lint lint: Disable eqeqeq in legacy configuration 2019-11-11 23:51:17 +00:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson build: Run postinstall script where necessary 2018-04-09 19:19:33 +00:00
po Update Indonesian translation 2019-11-10 02:35:26 +00:00
src Stop referring to ClutterTexture 2019-11-12 22:05:13 +01:00
subprojects gvc: Update submodule to up-to-date version 2019-02-28 21:59:08 +01:00
test Add convert_xml test 2019-03-04 20:55:15 +00:00
tests cleanup: Replace deprecated lower/raise calls 2019-11-06 09:42:57 +01:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore Ignore '.vscode' folder for users of that editor 2019-04-02 17:37:31 +00:00
.gitlab-ci.yml ci: Run tests through dbus-run-session 2019-10-30 19:43:53 +01:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
cldr2json.py Fix override for fr-CA 2019-03-04 20:55:15 +00:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Clean up list of maintainers 2019-10-16 12:47:05 +02:00
HACKING.md docs: Update actor and delegate_ paragraph in HACKING 2019-10-16 15:26:13 +00:00
meson_options.txt extensions-tool: Start import 2019-08-21 18:28:02 +02:00
meson.build environment: Use gjs smart GObject GTypeName computation 2019-10-29 18:38:35 +00:00
NEWS Bump version to 3.35.1 2019-10-12 22:38:36 +02:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00
README.mdwn Add basic documentation 2019-03-04 20:55:15 +00:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.