isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4340170e94
gnome-shell/js/ui
History
Florian Müllner 6995c2fa9f shellInfo: Don't destroy source on undo 
Destroying the source from an action callback will result in the
notification being destroyed twice:

 - source.destroy() destroys all its notifications

 - a notification destroys itself after an action
   was activated

This results in unwanted log spam when attempting to dispose the
notification for a second time.

There is actually no good reason for destroying the source explicitly,
as sources already self-destruct with their last notification.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4457

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1908>
2021-07-13 12:38:51 +00:00
..
components polkitAgent: Ensure cleanup if dialog wasn't shown 2021-02-11 13:48:54 +01:00
status status/power: Always sync after creating proxy 2021-06-28 20:49:43 +00:00
accessDialog.js portal: Own org.gnome.Shell.Portal for the access portal 2021-06-05 21:29:52 -03:00
altTab.js altTab: Avoid allocation cycle when showing CyclerHighlight 2021-05-11 17:36:29 +02:00
animation.js st/widget: Remove get_resource_scale function 2020-06-30 13:42:18 +00:00
appDisplay.js appDisplay: Add :gesture-modes property 2021-05-12 01:02:19 +02:00
appFavorites.js appFavorites: Add eog to rename list 2020-05-02 00:16:28 +02:00
audioDeviceSelection.js audioDeviceSelection: Ensure close() is called with no arguments 2021-04-19 19:12:59 +02:00
background.js background: Check xml mime type instead of extension 2021-04-16 19:53:53 +05:00
backgroundMenu.js cleanup: Avoid unnecessary parentheses 2019-11-11 19:25:14 +00:00
barLevel.js cleanup: Define GObject accessors in camelCase 2021-02-03 20:19:29 +01:00
boxpointer.js boxpointer: Handle non-widget source actors 2021-06-29 22:47:50 +02:00
calendar.js calendar: Vertically center align week numbers 2020-08-21 21:40:22 +03:00
checkBox.js checkbox: Improve accessibility of check boxes for Orca users 2020-03-29 12:56:33 +00:00
closeDialog.js closeDialog: Remove transitions before resetting dialog 2020-03-23 15:27:47 +00:00
ctrlAltTab.js ctrlAltTab: Fix usage of bind_cairo_surface_property 2021-03-08 09:21:25 +00:00
dash.js overviewControls: Limit Dash height to 15% of the overview's 2021-02-11 22:31:50 +00:00
dateMenu.js dateMenu: Fix temperature edge case 2020-12-22 09:27:45 +00:00
dialog.js dialog: Ensure action callback is called with no arguments 2021-04-19 19:12:59 +02:00
dnd.js dnd: Immediately start drag done by pointer devices 2021-05-31 10:59:11 -03:00
edgeDragAction.js keyboard: Handle edge drag gesture cancellation 2021-02-17 15:45:01 +00:00
endSessionDialog.js endSessionDialog: Only show logout inhibiting apps 2021-02-24 15:31:03 +00:00
environment.js js: Require Soup 2.4 2021-02-26 12:28:21 +00:00
extensionDownloader.js extensionDownloader: Use POST request for checking updates 2021-03-31 13:31:00 +04:00
extensionSystem.js extensionSystem: Fix opening Extensions app from notification 2021-01-26 17:12:04 +01:00
focusCaretTracker.js cleanup: Prefer template strings 2019-07-05 11:32:31 +00:00
grabHelper.js grabHelper: Propagate events while this._ignoreUntilRelease 2021-05-11 16:13:49 +00:00
ibusCandidatePopup.js ibusCandidatePopup: Use plain actor as dummy cursor 2021-06-29 22:47:58 +02:00
iconGrid.js iconGrid: Disconnect signals on destroy 2021-07-08 23:17:01 +00:00
inhibitShortcutsDialog.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
kbdA11yDialog.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
keyboard.js keyboard: Always emit ::pressed late on keys with variants 2021-04-27 22:02:53 +02:00
layout.js overview: Implement startup animation 2021-03-02 23:14:07 +00:00
lightbox.js lightbox: Fix shader effect 2021-02-24 09:52:45 +00:00
locatePointer.js locatePointer: Bind ripples creation to settings 2019-09-09 19:28:18 +00:00
lookingGlass.js lookingGlass: Use symbolic icons on the toolbar 2021-06-14 18:51:30 +00:00
magnifier.js Magnifier: Filter caret tracking in gnome magnifier 2021-06-28 21:28:10 +00:00
main.js main: Use session mode property for welcome dialog 2021-04-06 18:57:39 +00:00
messageList.js messageList: Drop sync_pointer() after relayouts 2021-02-14 13:57:56 +00:00
messageTray.js messageTray: Always remove destroyed banners 2021-07-13 12:38:51 +00:00
modalDialog.js switcherPopup: Dismiss when a system modal dialog opens 2019-12-06 19:55:39 +01:00
mpris.js mpris: Hide unused elements to leave more space for the title 2021-02-04 22:42:08 +00:00
notificationDaemon.js notificationDaemon: Fix icon-choosing logic 2021-02-01 13:58:20 +00:00
osdMonitorLabeler.js cleanup: Avoid unnecessary parentheses 2019-11-11 19:25:14 +00:00
osdWindow.js cleanup: Avoid unnecessary parentheses 2019-11-11 19:25:14 +00:00
overview.js shellInfo: Don't destroy source on undo 2021-07-13 12:38:51 +00:00
overviewControls.js overviewControls: Fix warning on shutdown 2021-07-08 23:17:01 +00:00
padOsd.js cleanup: Define GObject accessors in camelCase 2021-02-03 20:19:29 +01:00
pageIndicators.js pageIndicators: Remove animated indicators 2021-02-03 09:55:29 +01:00
panel.js appMenu: Only show Open Windows, if there are at least 2 windows 2021-04-29 12:22:38 +02:00
panelMenu.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
pointerA11yTimeout.js ui: Use ClutterSeat for keyboard/pointer a11y 2020-01-30 17:49:08 +00:00
pointerWatcher.js js: Get idle monitor from backend 2021-05-18 13:42:52 +00:00
popupMenu.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
remoteSearch.js remoteSearch: Fetch enabled/disabled list once 2021-04-02 19:07:56 +00:00
ripples.js cleanup: Require "dangling" commas 2019-11-11 19:25:14 +00:00
runDialog.js runDialog: Let history trim input 2021-02-13 08:58:20 +00:00
screenShield.js js: Get idle monitor from backend 2021-05-18 13:42:52 +00:00
screenshot.js screenshot: Ignore events in SelectArea after making a selection 2021-04-28 11:40:19 +00:00
scripting.js scripting: Switch to standard async/await pattern 2020-08-12 15:43:38 +00:00
search.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
searchController.js searchController: Get rid of activePage reference in key handling 2021-02-17 02:31:32 +01:00
sessionMode.js main: Use session mode property for welcome dialog 2021-04-06 18:57:39 +00:00
shellDBus.js shellDBus: Properly return from D-Bus methods 2021-06-17 21:03:58 +00:00
shellEntry.js shellEntry: Restore natural-height-set instead of forcing it 2020-02-22 16:58:01 +00:00
shellMountOperation.js cleanup: Don't linebreak before closing parentheses 2020-04-28 09:04:49 +00:00
slider.js js: Add missing chain-ups in vfuncs 2020-03-27 10:39:58 +01:00
swipeTracker.js swipeTracker: Remove unused property 2021-03-13 22:32:23 +00:00
switcherPopup.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
switchMonitor.js switchMonitor: Center align switcher icon's label 2020-01-02 13:03:08 +05:30
unlockDialog.js js: Get idle monitor from backend 2021-05-18 13:42:52 +00:00
userWidget.js theme: Don't draw border around symbolic user-icon 2020-12-17 21:46:41 +01:00
welcomeDialog.js welcomeDialog: Hide overview when taking tour 2021-02-19 17:18:50 +01:00
windowAttentionHandler.js messageTray: Don't create notification policy on demand 2020-03-26 18:52:10 +00:00
windowManager.js windowManager: Remove timeout on starting X11 services 2021-06-15 11:24:59 +02:00
windowMenu.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
windowPreview.js windowPreview: Make St.Label use single line mode 2021-04-28 14:29:19 +02:00
workspace.js workspace: Update WorkspaceLayout workarea on changes 2021-05-11 02:36:54 +02:00
workspaceAnimation.js workspaceAnimation: Allow long swipes in session 2021-05-30 12:02:12 -03:00
workspacesView.js workspacesView: Queue relayout when overview adjustment value change 2021-05-12 18:08:55 +00:00
workspaceSwitcherPopup.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
workspaceThumbnail.js workspaceThumbnail: Destroy thumbnails on destruction 2021-05-25 12:43:32 -03:00
xdndHandler.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00