isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
gnome-shell/js/ui
History
Jonas Ådahl 367d40d31b appDisplay: Don't have goToPage clamp to negative page index 
The nPages property can be 0, which is the case in a stripped down CI
image without a single app to be listed, which means we can't clamp to
`nPages - 1`, since that'll give us a negative index and the following
error:

(gnome-shell:266): Gjs-CRITICAL **: 16:48:56.633: JS ERROR: Error: Page -2 does not exist at IconGrid
getItemsAtPage@resource:///org/gnome/shell/ui/iconGrid.js:1383:19
_translatePreviousPageIcons@resource:///org/gnome/shell/ui/appDisplay.js:323:34
_syncPageIndicators@resource:///org/gnome/shell/ui/appDisplay.js:396:14
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:445:14
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:1236:29
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:1582:15
_init/<@resource:///org/gnome/shell/ui/appDisplay.js:499:18
_init/pagesChangedId<@resource:///org/gnome/shell/ui/iconGrid.js:1137:24
_removePage@resource:///org/gnome/shell/ui/iconGrid.js:454:14
_removeItemData@resource:///org/gnome/shell/ui/iconGrid.js:495:18
moveItem@resource:///org/gnome/shell/ui/iconGrid.js:854:14
moveItem@resource:///org/gnome/shell/ui/iconGrid.js:1277:29
_moveItem@resource:///org/gnome/shell/ui/appDisplay.js:1194:20
_redisplay/<@resource:///org/gnome/shell/ui/appDisplay.js:1085:22
_redisplay@resource:///org/gnome/shell/ui/appDisplay.js:1080:17
_redisplay@resource:///org/gnome/shell/ui/appDisplay.js:1370:15
_init/<@resource:///org/gnome/shell/ui/appDisplay.js:633:24
_initializeManager@resource:///org/gnome/shell/misc/parentalControlsManager.js:95:14
async*_init@resource:///org/gnome/shell/misc/parentalControlsManager.js:63:14
ParentalControlsManager@resource:///org/gnome/shell/misc/parentalControlsManager.js:55:4
getDefault@resource:///org/gnome/shell/misc/parentalControlsManager.js:42:22
start@resource:///org/gnome/shell/ui/main.js:184:29
@resource:///org/gnome/shell/ui/init.js:6:17

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1349>
2022-11-25 22:09:37 +01:00
..
components
js: Use async D-Bus wrappers
2022-08-01 18:51:14 +00:00
status
status/remoteAccess: Don't override existing style classes
2022-11-18 18:50:43 +01:00
accessDialog.js
accessDialog: Change fallback button labels
2022-11-19 00:42:26 +00:00
altTab.js
altTab: Always include label in thumbnail
2022-10-18 18:04:57 +00:00
animation.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
appDisplay.js
appDisplay: Don't have goToPage clamp to negative page index
2022-11-25 22:09:37 +01:00
appFavorites.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
appMenu.js
appMenu: Hide overview when pressing on 'Show Details'
2022-06-09 17:51:46 +02:00
audioDeviceSelection.js
cleanup: Use new indentation style for object literals
2022-02-23 12:23:52 +00:00
background.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
backgroundMenu.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
barLevel.js
…
boxpointer.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
calendar.js
calendar: Unbind settings when destroying
2022-11-25 22:09:37 +01:00
checkBox.js
…
closeDialog.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
ctrlAltTab.js
cleanup: Use new indentation style for object literals
2022-02-23 12:23:52 +00:00
dash.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
dateMenu.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
dialog.js
dialog: Remove incorrect disconnectObject()
2022-11-25 22:09:37 +01:00
dnd.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
edgeDragAction.js
edgeDragAction: Change edge trigger threshold to AFTER
2022-05-27 09:29:26 +00:00
endSessionDialog.js
loginManager: Return objects instead of multiple booleans
2022-08-01 20:58:37 +02:00
environment.js
environment: Set time zero when animations are disabled
2022-11-04 14:14:34 +01:00
extensionDownloader.js
js: Use templates for non-translatable strings
2022-02-12 12:29:52 +00:00
extensionSystem.js
extensionSystem: Check if mode is supported when loading
2022-07-27 14:01:30 +00:00
focusCaretTracker.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
grabHelper.js
Require both mouse and keyboard grabs for some grabs to be successful
2022-05-04 17:28:08 +00:00
ibusCandidatePopup.js
ibusCandidatePopup: Prevent it from covering screenshot UI
2022-07-04 13:38:15 +00:00
iconGrid.js
iconGrid: Always call findBestModeForSize()
2022-08-10 15:16:36 +00:00
inhibitShortcutsDialog.js
inhibitShorcutsDialog: Fix permission check
2022-11-19 00:48:25 +00:00
init.js
init: Set console log domain
2021-09-01 14:55:47 +00:00
kbdA11yDialog.js
kbdA11yDialog: Use MetaKeyboardA11yFlags
2022-06-16 09:38:20 +00:00
keyboard.js
keyboard: Change osk menu entry to control-center keyboard pane
2022-11-24 13:49:55 +01:00
layout.js
layout: Initialize regions unconditionally
2022-11-18 13:16:06 +00:00
lightbox.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
locatePointer.js
…
lookingGlass.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
magnifier.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00
main.js
environment: Remove inline import of extensionUtils
2022-07-06 13:40:44 -04:00
messageList.js
messageList: Only close messages via delete key if they can be closed
2022-06-04 15:23:45 +02:00
messageTray.js
signalTracker: Explicitly register destroyable types
2022-03-06 00:10:03 +00:00
modalDialog.js
Require both mouse and keyboard grabs for some grabs to be successful
2022-05-04 17:28:08 +00:00
mpris.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
notificationDaemon.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
osdMonitorLabeler.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
osdWindow.js
osdWindow: Implement new OSD design
2022-02-12 15:28:52 +00:00
overview.js
overview: Start animation after setting coverPane initial state
2022-11-25 15:19:37 +00:00
overviewControls.js
overview: Make preparation to enter/leave overview explicit
2022-11-25 15:19:37 +00:00
padOsd.js
padOsd: Figure out label/edition UI positions from unchanged fonts
2022-09-02 19:24:47 +00:00
pageIndicators.js
cleanup: Use new indentation style for object literals
2022-02-23 12:23:52 +00:00
panel.js
panel: Add PanelMenu.Button menu when menu-set is emitted
2022-09-17 17:56:21 +00:00
panelMenu.js
js: Use templates for non-translatable strings
2022-02-12 12:29:52 +00:00
pointerA11yTimeout.js
…
pointerWatcher.js
js: Get idle monitor from backend
2021-05-18 13:42:52 +00:00
popupMenu.js
popupMenu: Close quick settings when activating settings action
2022-08-02 16:05:28 +00:00
quickSettings.js
quickSettings: Make parent StWidget have a 0x0 size
2022-11-16 16:51:49 +00:00
remoteSearch.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
ripples.js
cleanup: Use new indentation style for object literals
2022-02-23 12:23:52 +00:00
runDialog.js
runDialog: Use single quotes for Wayland restart warning
2022-05-31 18:35:41 +00:00
screenShield.js
screenShield: Only wake up screen when active
2022-08-10 16:31:42 +00:00
screenshot.js
screenshot: Cache ScreencastSupported property
2022-11-09 11:15:04 +00:00
scripting.js
scripting: Terminate using meta_context_terminate()
2022-11-25 22:09:37 +01:00
search.js
search: Use async functions instead of callbacks
2022-08-01 18:51:14 +00:00
searchController.js
searchController: Avoid event.set_source() API
2022-03-04 12:27:34 +00:00
sessionMode.js
panel: Remove aggregate menu
2022-08-10 16:37:15 +00:00
shellDBus.js
cleanup: Use deepUnpack() intead of deep_unpack()
2022-08-10 10:29:24 +00:00
shellEntry.js
shellEntry: Remove unused variable
2022-10-14 22:32:30 +00:00
shellMountOperation.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
slider.js
slider: Use Clutter.grab() for implicit grab
2022-01-29 01:16:29 +01:00
swipeTracker.js
swipeTracker: Set up 1fg drag gesture in capture phase
2022-08-10 17:11:26 +00:00
switcherPopup.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
switchMonitor.js
switchMonitor: Fix initial selection on desktop
2022-08-31 00:38:49 +00:00
unlockDialog.js
lockScreen: Extend modal grab to entire uiGroup
2022-05-18 20:16:10 +02:00
userWidget.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
welcomeDialog.js
cleanup: Use new indentation style for object literals
2022-02-23 12:23:52 +00:00
windowAttentionHandler.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
windowManager.js
windowManager: Get the active workspace index directly
2022-11-14 20:03:32 +01:00
windowMenu.js
windowMenu: Add an entry to take a screenshot
2022-02-12 00:20:54 +00:00
windowPreview.js
Js: Use new :icon-name property
2022-05-06 13:39:40 +00:00
workspace.js
workspace: Port WorkspaceBackground allocate to C
2022-08-03 12:30:31 +00:00
workspaceAnimation.js
workspaceAnimation: Get time outside of the animation-complete callback
2022-03-13 00:06:03 +00:00
workspacesView.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
workspaceSwitcherPopup.js
js: Use (dis)connectObject()
2022-03-04 14:14:37 +00:00
workspaceThumbnail.js
workspaceThumbnail: Use new helper function when accepting drops
2022-03-31 17:56:49 +02:00
xdndHandler.js
Adopt EventEmitter class instead of injecting Signal methods
2022-07-04 18:30:49 -04:00