3d8b866a9d
The code to highlight matches did not properly escape the passed in text as for markup before adding its highlighting markup. This lead to some search result descriptions not showing up, because their descriptions contained characters, such as "<", that would have to be escaped when used in markup or otherwise lead to invalid markup. To work around this some search providers wrongly started escaping the description on their end before sending them to gnome-shell. This lead to another issue. Now if the highlighter was trying to highlight the term "a", and the escaped description contained "'", the "a" in that would be considered a match and surrounded by "<b></b>". This however would also generate invalid markup, again leading to an error and the description not being shown. Fix this by always escaping the passed in string before applying the highlights in such a way that there are no matches within entities. This also means that search providers that escaped their description strings will now show up with the markup syntax. This will have to be fixed separately in the affected search providers. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4791 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2033>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.