38e31b9f0d
Theme node invalidation stops at unmapped widgets, and widgets that forget to chain up to the default ::style-changed implementation. This may leave stale nodes that were invalidated on StThemeContext::changed, but are still set on widgets, and maybe used for CSS property lookups. Make sure that theme node invalidation happens always by moving propagation outside the vfunc, and ensure the theme nodes are reset across the full actor tree. Emission of ::style-changed, and obtaining a new theme node may be delayed till when the actor is mapped. The theme node is also cleared after unparenting an actor to avoid stale references. This ensures that all widgets get their theme node cleared after stylesheet changes, instead of maybe being left with a theme node that's been cleared of all its properties. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2541 https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1223 (cherry picked from commit 325ff73c5b94f713073f117f0cb6a01049c5052f)
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.