2b87bb015c
We've been dangling on the edge of unsafety, unnoticed, for a little while about the reference count safety of ShellScreenshot. GJS owns the entire reference count, so as soon as it goes out of scope it could die, causing GJS to try and fetch the corresponding wrapper object for a stale pointer. We haven't seen any crashes because of luck -- SpiderMonkey tries to group together deallocations to limit GC pauses, and there isn't really a lot of GC pressure in the duration that a screenshot happens, so we tend to be mostly stable. But in the case that you create a lot of objects while a screenshot is going on, by hammering the "Print Screen" button, for example, you can destroy the GObject before the callback finishes. https://bugzilla.gnome.org/show_bug.cgi?id=672775
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: http://live.gnome.org/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.